Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1672483004: DebugVisualizers: Support Oilpan (Closed)

Created:
4 years, 10 months ago by kojii
Modified:
4 years, 10 months ago
Reviewers:
brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DebugVisualizers: Support Oilpan This patch enables Oilpan data structures in the debug visualizers. Since Oilpan was enabled by default, some m_ptr needs to change to m_raw. Committed: https://crrev.com/c2be334666b6916d5c149a12e4b7929307026c88 Cr-Commit-Position: refs/heads/master@{#374815}

Patch Set 1 #

Patch Set 2 : Fix anonymous LayoutObject #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M tools/win/DebugVisualizers/webkit.natvis View 1 3 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kojii
PTAL.
4 years, 10 months ago (2016-02-05 06:36:35 UTC) #3
brucedawson
Sorry for the delay - I missed seeing the notification. lgtm.
4 years, 10 months ago (2016-02-10 23:53:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672483004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672483004/20001
4 years, 10 months ago (2016-02-11 00:36:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-11 01:06:46 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:33:32 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2be334666b6916d5c149a12e4b7929307026c88
Cr-Commit-Position: refs/heads/master@{#374815}

Powered by Google App Engine
This is Rietveld 408576698