Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2008)

Unified Diff: Source/devtools/front_end/sdk/RuntimeModel.js

Issue 1672443003: Fix devtools bugs Fix a spurious layout test failure (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/2454_1
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/console/ConsoleView.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/RuntimeModel.js
diff --git a/Source/devtools/front_end/sdk/RuntimeModel.js b/Source/devtools/front_end/sdk/RuntimeModel.js
index ed4de503f9d7e62d404488e107fc2363d61e3b59..46fa282032fa7413aca9b5a806e2c3981cc710be 100644
--- a/Source/devtools/front_end/sdk/RuntimeModel.js
+++ b/Source/devtools/front_end/sdk/RuntimeModel.js
@@ -275,7 +275,7 @@ WebInspector.ExecutionContext.prototype = {
{
// Dart adds the isEvaluateOnCallFrameMode option to make debugging multiple Dart libraries more usable.
// FIXME: It will be moved to separate ExecutionContext.
- if (this.debuggerModel.selectedCallFrame() && this._debuggerModel.isEvaluateOnCallFrameMode()) {
+ if (this.debuggerModel.selectedCallFrame() && this.debuggerModel.isEvaluateOnCallFrameMode()) {
this.debuggerModel.evaluateOnSelectedCallFrame(expression, objectGroup, includeCommandLineAPI, doNotPauseOnExceptionsAndMuteConsole, returnByValue, generatePreview, callback);
return;
}
@@ -337,13 +337,13 @@ WebInspector.ExecutionContext.prototype = {
*/
getCompletions: function(expression, callback)
{
- var selectedCallFrame = WebInspector.debuggerModel.selectedCallFrame();
+ var selectedCallFrame = this.debuggerModel.selectedCallFrame();
// Dart/Modules specific tweak: don't use the call frame if we are
// we have explicitly selected an execution context for the console
// that is part of a different library than the current call frame.
- if (selectedCallFrame && this._debuggerModel.isEvaluateOnCallFrameMode()) {
+ if (selectedCallFrame && this.debuggerModel.isEvaluateOnCallFrameMode()) {
selectedCallFrame.getCompletions(expression, callback);
return;
}
@@ -359,8 +359,8 @@ WebInspector.ExecutionContext.prototype = {
*/
completionsForExpression: function(expressionString, prefix, force, completionsReadyCallback)
{
- if ((this._debuggerModel.selectedCallFrame() && this._debuggerModel.selectedCallFrame().script.language == "Dart") ||
- (!this._debuggerModel.selectedCallFrame() && this.language == "Dart")) {
+ if ((this.debuggerModel.selectedCallFrame() && this.debuggerModel.selectedCallFrame().script.language == "Dart") ||
+ (!this.debuggerModel.selectedCallFrame() && this.language == "Dart")) {
return this.completionsForExpressionDart(expressionString, prefix, force, completionsReadyCallback);
}
@@ -545,7 +545,7 @@ WebInspector.ExecutionContext.prototype = {
var results = [];
if (!expressionString) {
- var selectedCallFrame = WebInspector.debuggerModel.selectedCallFrame();
+ var selectedCallFrame = this.debuggerModel.selectedCallFrame();
var dartContext = false;
if (selectedCallFrame) {
« no previous file with comments | « Source/devtools/front_end/console/ConsoleView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698