Source/bindings/core/dart/DartInspectorRuntimeAgent.h - Issue 1672443003: Fix devtools bugs Fix a spurious layout test failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/dart/DartInspectorRuntimeAgent.h

Issue 1672443003: Fix devtools bugs Fix a spurious layout test failure (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/2454_1

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/dart/DartInspectorDebuggerAgent.cpp ('k') | Source/bindings/core/dart/DartInspectorRuntimeAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/dart/DartInspectorRuntimeAgent.h

diff --git a/Source/bindings/core/dart/DartInspectorRuntimeAgent.h b/Source/bindings/core/dart/DartInspectorRuntimeAgent.h

index 845b80bd22904a2baceaa813e3e15f17f5a5b012..6a3a0cdf209c031e708fee959f03cbb3475f31bd 100644

--- a/Source/bindings/core/dart/DartInspectorRuntimeAgent.h

+++ b/Source/bindings/core/dart/DartInspectorRuntimeAgent.h

@@ -86,7 +86,7 @@ public:

void getProperties(ErrorString*, const String& objectId, const bool* ownProperties, const bool* accessorPropertiesOnly, RefPtr<TypeBuilder::Array<TypeBuilder::Runtime::PropertyDescriptor> >& result, RefPtr<TypeBuilder::Array<TypeBuilder::Runtime::InternalPropertyDescriptor> >& internalProperties);

void getProperty(ErrorString*, const String& objectId, const RefPtr<JSONArray>& propertyPath, RefPtr<TypeBuilder::Runtime::RemoteObject>& result, TypeBuilder::OptOutput<bool>* wasThrown);

- int addExecutionContextToFrontendHelper(DartScriptState*, bool isPageContext, const String& name, const String& frameId);

+ void addExecutionContextToFrontendHelper(DartScriptState*, bool isPageContext, const String& name, const String& frameId);

private:

DartInjectedScript* injectedScriptForEval(ErrorString*, const int* executionContextId);