Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Side by Side Diff: src/mips/ic-mips.cc

Issue 167243003: MIPS: Don't mix handler flags into regular flag computation. (Closed) Base URL: https://github.com/v8/v8.git@gbl
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 341
342 void LoadIC::GenerateMegamorphic(MacroAssembler* masm, 342 void LoadIC::GenerateMegamorphic(MacroAssembler* masm,
343 ExtraICState extra_state) { 343 ExtraICState extra_state) {
344 // ----------- S t a t e ------------- 344 // ----------- S t a t e -------------
345 // -- a2 : name 345 // -- a2 : name
346 // -- ra : return address 346 // -- ra : return address
347 // -- a0 : receiver 347 // -- a0 : receiver
348 // ----------------------------------- 348 // -----------------------------------
349 349
350 // Probe the stub cache. 350 // Probe the stub cache.
351 Code::Flags flags = Code::ComputeFlags( 351 Code::Flags flags = Code::ComputeHandlerFlags(Code::LOAD_IC, extra_state);
352 Code::HANDLER, MONOMORPHIC, extra_state,
353 Code::NORMAL, Code::LOAD_IC);
354 masm->isolate()->stub_cache()->GenerateProbe( 352 masm->isolate()->stub_cache()->GenerateProbe(
355 masm, flags, a0, a2, a3, t0, t1, t2); 353 masm, flags, a0, a2, a3, t0, t1, t2);
356 354
357 // Cache miss: Jump to runtime. 355 // Cache miss: Jump to runtime.
358 GenerateMiss(masm); 356 GenerateMiss(masm);
359 } 357 }
360 358
361 359
362 void LoadIC::GenerateNormal(MacroAssembler* masm) { 360 void LoadIC::GenerateNormal(MacroAssembler* masm) {
363 // ----------- S t a t e ------------- 361 // ----------- S t a t e -------------
(...skipping 811 matching lines...) Expand 10 before | Expand all | Expand 10 after
1175 // The slow case calls into the runtime to complete the store without causing 1173 // The slow case calls into the runtime to complete the store without causing
1176 // an IC miss that would otherwise cause a transition to the generic stub. 1174 // an IC miss that would otherwise cause a transition to the generic stub.
1177 ExternalReference ref = 1175 ExternalReference ref =
1178 ExternalReference(IC_Utility(kKeyedStoreIC_Slow), masm->isolate()); 1176 ExternalReference(IC_Utility(kKeyedStoreIC_Slow), masm->isolate());
1179 1177
1180 __ TailCallExternalReference(ref, 3, 1); 1178 __ TailCallExternalReference(ref, 3, 1);
1181 } 1179 }
1182 1180
1183 1181
1184 void StoreIC::GenerateMegamorphic(MacroAssembler* masm, 1182 void StoreIC::GenerateMegamorphic(MacroAssembler* masm,
1185 ExtraICState extra_ic_state) { 1183 ExtraICState extra_state) {
1186 // ----------- S t a t e ------------- 1184 // ----------- S t a t e -------------
1187 // -- a0 : value 1185 // -- a0 : value
1188 // -- a1 : receiver 1186 // -- a1 : receiver
1189 // -- a2 : name 1187 // -- a2 : name
1190 // -- ra : return address 1188 // -- ra : return address
1191 // ----------------------------------- 1189 // -----------------------------------
1192 1190
1193 // Get the receiver from the stack and probe the stub cache. 1191 // Get the receiver from the stack and probe the stub cache.
1194 Code::Flags flags = Code::ComputeFlags( 1192 Code::Flags flags = Code::ComputeHandlerFlags(Code::STORE_IC, extra_state);
1195 Code::HANDLER, MONOMORPHIC, extra_ic_state,
1196 Code::NORMAL, Code::STORE_IC);
1197 masm->isolate()->stub_cache()->GenerateProbe( 1193 masm->isolate()->stub_cache()->GenerateProbe(
1198 masm, flags, a1, a2, a3, t0, t1, t2); 1194 masm, flags, a1, a2, a3, t0, t1, t2);
1199 1195
1200 // Cache miss: Jump to runtime. 1196 // Cache miss: Jump to runtime.
1201 GenerateMiss(masm); 1197 GenerateMiss(masm);
1202 } 1198 }
1203 1199
1204 1200
1205 void StoreIC::GenerateMiss(MacroAssembler* masm) { 1201 void StoreIC::GenerateMiss(MacroAssembler* masm) {
1206 // ----------- S t a t e ------------- 1202 // ----------- S t a t e -------------
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
1353 } else { 1349 } else {
1354 ASSERT(Assembler::IsBne(branch_instr)); 1350 ASSERT(Assembler::IsBne(branch_instr));
1355 patcher.ChangeBranchCondition(eq); 1351 patcher.ChangeBranchCondition(eq);
1356 } 1352 }
1357 } 1353 }
1358 1354
1359 1355
1360 } } // namespace v8::internal 1356 } } // namespace v8::internal
1361 1357
1362 #endif // V8_TARGET_ARCH_MIPS 1358 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698