Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1672383002: Add comments to public libraries (Closed)

Created:
4 years, 10 months ago by Brian Wilkerson
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -8 lines) Patch
M pkg/analyzer/lib/dart/ast/ast.dart View 1 chunk +32 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/dart/ast/visitor.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/dart/element/element.dart View 1 chunk +32 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/dart/element/type.dart View 4 chunks +26 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/dart/element/visitor.dart View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 10 months ago (2016-02-06 18:49:38 UTC) #2
scheglov
On 2016/02/06 18:49:38, Brian Wilkerson wrote: LGTM
4 years, 10 months ago (2016-02-06 18:55:07 UTC) #3
Brian Wilkerson
4 years, 10 months ago (2016-02-07 00:27:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a9d0e2bf7674ff34db54b31502390bfac4d41c50 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698