Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issue 1672303002: Fix --no-lazy-dispatchers in the JIT. (Closed)

Created:
4 years, 10 months ago by rmacnak
Modified:
4 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix --no-lazy-dispatchers in the JIT. Broken since bac82e2592238663c13dbb324a7dcb1da1a5b7ba. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/3b4a9e7e013355c223e1cd4cb6424942acaefa93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +1 line, -3 lines 0 comments Download
A + tests/standalone/no_lazy_dispatchers_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 10 months ago (2016-02-06 01:22:05 UTC) #2
Florian Schneider
lgtm
4 years, 10 months ago (2016-02-08 08:08:41 UTC) #3
rmacnak
4 years, 10 months ago (2016-02-08 18:23:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3b4a9e7e013355c223e1cd4cb6424942acaefa93 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698