Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1672283002: Remove CFX_PtrArray from xfa/include/fwl (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove CFX_PtrArray from xfa/include/fwl Fix IWYU in stl_util.h R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ddf2f339f603246107451931d16245c8b7d1d7c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -199 lines) Patch
M third_party/base/stl_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/include/fwl/lightwidget/listbox.h View 3 chunks +55 lines, -43 lines 0 comments Download
M xfa/include/fwl/lightwidget/theme.h View 2 chunks +8 lines, -4 lines 0 comments Download
M xfa/include/fwl/theme/widgettp.h View 5 chunks +20 lines, -7 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/listbox.cpp View 5 chunks +36 lines, -38 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/theme.cpp View 1 chunk +57 lines, -75 lines 0 comments Download
M xfa/src/fwl/src/theme/widgettp.cpp View 4 chunks +24 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
Pls. review.
4 years, 10 months ago (2016-02-06 00:41:37 UTC) #3
Lei Zhang
lgtm
4 years, 10 months ago (2016-02-06 01:05:10 UTC) #4
Tom Sepez
4 years, 10 months ago (2016-02-08 17:34:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ddf2f339f603246107451931d16245c8b7d1d7c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698