Enforce containing block requirement for IntersectionObserver.

Enforce containing block requirement for IntersectionObserver.

Context: https://github.com/WICG/IntersectionObserver/issues/84

Only generate notifications if the target Element is a descendant
of the root in the containing block chain.

Also consolidated all of the sanity-checking code into computeGeometry().

BUG=540528
R=ojan@chromium.org,esprehn@chromium.org

Committed: https://crrev.com/099be5c161399ca0d0304e5a187b7a93e7b948f4
Cr-Commit-Position: refs/heads/master@{#375000}

[szager1, 2016-02-06 00:26:02]

Description was changed from

==========
Enforce containing block requirement for IntersectionObserver.

Context: https://github.com/WICG/IntersectionObserver/issues/84

Only generate notifications if the target Element is a descendant
of the root in the containing block chain.

BUG=540528
R=ojan@chromium.org,esprehn@chromium.org
==========

to

==========
Enforce containing block requirement for IntersectionObserver.

Context: https://github.com/WICG/IntersectionObserver/issues/84

Only generate notifications if the target Element is a descendant
of the root in the containing block chain.

Also consolidated all of the sanity-checking code into computeGeometry().

BUG=540528
R=ojan@chromium.org,esprehn@chromium.org
==========

[szager1, 2016-02-08 18:04:37]

ping

[esprehn, 2016-02-08 21:36:08]

I'd rather we enforced the same frame requirement first, crossing iframes and
doing this containing block check is unfortunate.

[esprehn, 2016-02-08 21:36:38]

This also doesn't remove all the element ancestor checking code, we should
remove that in this same patch.

[szager1, 2016-02-09 07:17:39]

On 2016/02/08 21:36:08, esprehn wrote:
> I'd rather we enforced the same frame requirement first, crossing iframes and
> doing this containing block check is unfortunate.

Done.

[szager1, 2016-02-09 07:18:08]

On 2016/02/08 21:36:38, esprehn wrote:
> This also doesn't remove all the element ancestor checking code, we should
> remove that in this same patch.

Done, PTAL.

[szager1, 2016-02-10 18:25:56]

ping

[esprehn, 2016-02-11 06:15:23]

lgtm w/ nits fixed.

https://codereview.chromium.org/1672273002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IntersectionObservation.cpp (right):

https://codereview.chromium.org/1672273002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObservation.cpp:97: return
(descendantFrame && descendantFrame->tree().top() == ancestorFrame);
remove parens

https://codereview.chromium.org/1672273002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObservation.cpp:121: if
(!targetLayoutObject || !(targetLayoutObject->isBoxModelObject() ||
targetLayoutObject->isText()))
if (!targetLayoutObject)
  return false;
if (!targetLayoutObject->isBoxModelObject() && targetLayoutObject->isText()
  return false;

in general run demorgans.

[szager1, 2016-02-11 18:17:24]

https://codereview.chromium.org/1672273002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IntersectionObservation.cpp (right):

https://codereview.chromium.org/1672273002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObservation.cpp:97: return
(descendantFrame && descendantFrame->tree().top() == ancestorFrame);
On 2016/02/11 06:15:23, esprehn wrote:
> remove parens

Done.

https://codereview.chromium.org/1672273002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObservation.cpp:121: if
(!targetLayoutObject || !(targetLayoutObject->isBoxModelObject() ||
targetLayoutObject->isText()))
On 2016/02/11 06:15:23, esprehn wrote:
> if (!targetLayoutObject)
>   return false;
> if (!targetLayoutObject->isBoxModelObject() && targetLayoutObject->isText()
>   return false;
> 
> in general run demorgans.

Done.

[szager1, 2016-02-11 18:17:29]

The CQ bit was checked by szager@chromium.org

[szager1, 2016-02-11 18:17:29]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1672273002/#ps60001
(title: "nits")

[commit-bot: I haz the power, 2016-02-11 18:17:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672273002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672273002/60001

[commit-bot: I haz the power, 2016-02-11 21:37:05]

Description was changed from

==========
Enforce containing block requirement for IntersectionObserver.

Context: https://github.com/WICG/IntersectionObserver/issues/84

Only generate notifications if the target Element is a descendant
of the root in the containing block chain.

Also consolidated all of the sanity-checking code into computeGeometry().

BUG=540528
R=ojan@chromium.org,esprehn@chromium.org
==========

to

==========
Enforce containing block requirement for IntersectionObserver.

Context: https://github.com/WICG/IntersectionObserver/issues/84

Only generate notifications if the target Element is a descendant
of the root in the containing block chain.

Also consolidated all of the sanity-checking code into computeGeometry().

BUG=540528
R=ojan@chromium.org,esprehn@chromium.org
==========

[commit-bot: I haz the power, 2016-02-11 21:37:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-16 22:38:23]

Description was changed from

==========
Enforce containing block requirement for IntersectionObserver.

Context: https://github.com/WICG/IntersectionObserver/issues/84

Only generate notifications if the target Element is a descendant
of the root in the containing block chain.

Also consolidated all of the sanity-checking code into computeGeometry().

BUG=540528
R=ojan@chromium.org,esprehn@chromium.org
==========

to

==========
Enforce containing block requirement for IntersectionObserver.

Context: https://github.com/WICG/IntersectionObserver/issues/84

Only generate notifications if the target Element is a descendant
of the root in the containing block chain.

Also consolidated all of the sanity-checking code into computeGeometry().

BUG=540528
R=ojan@chromium.org,esprehn@chromium.org

Committed: https://crrev.com/099be5c161399ca0d0304e5a187b7a93e7b948f4
Cr-Commit-Position: refs/heads/master@{#375000}
==========

[commit-bot: I haz the power, 2016-02-16 22:38:24]

Patchset 4 (id:??) landed as
https://crrev.com/099be5c161399ca0d0304e5a187b7a93e7b948f4
Cr-Commit-Position: refs/heads/master@{#375000}