Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Issue 167223002: Fix directory layout for tools/memory_inspector tests. (Closed)

Created:
6 years, 10 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 10 months ago
Reviewers:
bulach
CC:
chromium-reviews, Philippe
Visibility:
Public.

Description

Fix directory layout for tools/memory_inspector tests. This cl rearranges the directory layout for the memory_inspector tests. This is to ensure that: - Every unittest lives side-by-side with the module being tested. - The mocks/helper class live in the unittest package. - Nobody has to hack the sys.path ever. - Every (test and non) module uses the "import memory_inspector.submodule" pattern consistently, without creating any namespace ambiguities. BUG=340294 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251413

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -190 lines) Patch
M tools/memory_inspector/PRESUBMIT.py View 1 chunk +4 lines, -5 lines 0 comments Download
A tools/memory_inspector/memory_inspector/core/backends_unittest.py View 1 1 chunk +53 lines, -0 lines 0 comments Download
A tools/memory_inspector/memory_inspector/core/memory_map_unittest.py View 1 chunk +39 lines, -0 lines 0 comments Download
A tools/memory_inspector/memory_inspector/core/stacktrace_unittest.py View 1 chunk +21 lines, -0 lines 0 comments Download
A + tools/memory_inspector/memory_inspector/unittest/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/memory_inspector/memory_inspector/unittest/mock_adb/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/memory_inspector/memory_inspector/unittest/mock_adb/adb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/memory_inspector/memory_inspector/unittest/mock_adb/mock_adb.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/memory_inspector/run_tests View 1 chunk +35 lines, -0 lines 0 comments Download
D tools/memory_inspector/tests/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/memory_inspector/tests/core_test.py View 1 chunk +0 lines, -115 lines 0 comments Download
D tools/memory_inspector/tests/mock_adb/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/memory_inspector/tests/mock_adb/adb View 1 chunk +0 lines, -40 lines 0 comments Download
D tools/memory_inspector/tests/mock_adb/mock_adb.py View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Primiano Tucci (use gerrit)
6 years, 10 months ago (2014-02-14 18:10:42 UTC) #1
bulach
lgtm, tiny nit. thanks! https://codereview.chromium.org/167223002/diff/40001/tools/memory_inspector/memory_inspector/core/backends_unittest.py File tools/memory_inspector/memory_inspector/core/backends_unittest.py (right): https://codereview.chromium.org/167223002/diff/40001/tools/memory_inspector/memory_inspector/core/backends_unittest.py#newcode53 tools/memory_inspector/memory_inspector/core/backends_unittest.py:53: self.assertTrue('key_1' in mock_backend_1.settings) nit: extra ...
6 years, 10 months ago (2014-02-14 18:19:08 UTC) #2
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 10 months ago (2014-02-14 18:51:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/167223002/90001
6 years, 10 months ago (2014-02-14 18:52:11 UTC) #4
Primiano Tucci (use gerrit)
https://codereview.chromium.org/167223002/diff/40001/tools/memory_inspector/memory_inspector/core/backends_unittest.py File tools/memory_inspector/memory_inspector/core/backends_unittest.py (right): https://codereview.chromium.org/167223002/diff/40001/tools/memory_inspector/memory_inspector/core/backends_unittest.py#newcode53 tools/memory_inspector/memory_inspector/core/backends_unittest.py:53: self.assertTrue('key_1' in mock_backend_1.settings) On 2014/02/14 18:19:08, bulach wrote: > ...
6 years, 10 months ago (2014-02-14 18:58:56 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 20:47:06 UTC) #6
Message was sent while issue was closed.
Change committed as 251413

Powered by Google App Engine
This is Rietveld 408576698