Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1672123002:
Make SkString movable. (Closed)
|
Created:
4 years, 10 months ago by bungeman-skia Modified:
4 years, 10 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionMake SkString movable.
This adds a move constructor and move assignment to SkString. This
allows elision of atomic increments and decrements on the fRec.
TBR=reed
Already agreed that moving is good.
Committed: https://skia.googlesource.com/skia/+/9d55297f1fd1ed0f74277fd95b4c59608220aa77
Patch Set 1 #
Total comments: 2
Patch Set 2 : Don't need 'this' on 'f' fields. #
Messages
Total messages: 18 (11 generated)
Description was changed from ========== Make SkString movable. This adds a move constructor and move assignment to SkString. This allows elision of atomic increments and decrements on the fRec. ========== to ========== Make SkString movable. This adds a move constructor and move assignment to SkString. This allows elision of atomic increments and decrements on the fRec. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Make SkString movable. This adds a move constructor and move assignment to SkString. This allows elision of atomic increments and decrements on the fRec. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Make SkString movable. This adds a move constructor and move assignment to SkString. This allows elision of atomic increments and decrements on the fRec. ==========
The CQ bit was checked by bungeman@google.com to run a CQ dry run
bungeman@google.com changed reviewers: + mtklein@google.com, reed@google.com
To go along with SkTArray changes.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672123002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_TIMED_OUT, no build URL)
lgtm https://codereview.chromium.org/1672123002/diff/1/src/core/SkString.cpp File src/core/SkString.cpp (right): https://codereview.chromium.org/1672123002/diff/1/src/core/SkString.cpp#newco... src/core/SkString.cpp:281: this->fRec = src.fRec; We can probably just write fRec = ... ?
Description was changed from ========== Make SkString movable. This adds a move constructor and move assignment to SkString. This allows elision of atomic increments and decrements on the fRec. ========== to ========== Make SkString movable. This adds a move constructor and move assignment to SkString. This allows elision of atomic increments and decrements on the fRec. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Make SkString movable. This adds a move constructor and move assignment to SkString. This allows elision of atomic increments and decrements on the fRec. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Make SkString movable. This adds a move constructor and move assignment to SkString. This allows elision of atomic increments and decrements on the fRec. ==========
Description was changed from ========== Make SkString movable. This adds a move constructor and move assignment to SkString. This allows elision of atomic increments and decrements on the fRec. ========== to ========== Make SkString movable. This adds a move constructor and move assignment to SkString. This allows elision of atomic increments and decrements on the fRec. TBR=reed Already agreed that moving is good. ==========
https://codereview.chromium.org/1672123002/diff/1/src/core/SkString.cpp File src/core/SkString.cpp (right): https://codereview.chromium.org/1672123002/diff/1/src/core/SkString.cpp#newco... src/core/SkString.cpp:281: this->fRec = src.fRec; On 2016/02/07 22:18:36, mtklein wrote: > We can probably just write fRec = ... ? Done.
The CQ bit was checked by bungeman@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com Link to the patchset: https://codereview.chromium.org/1672123002/#ps20001 (title: "Don't need 'this' on 'f' fields.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672123002/20001
Message was sent while issue was closed.
Description was changed from ========== Make SkString movable. This adds a move constructor and move assignment to SkString. This allows elision of atomic increments and decrements on the fRec. TBR=reed Already agreed that moving is good. ========== to ========== Make SkString movable. This adds a move constructor and move assignment to SkString. This allows elision of atomic increments and decrements on the fRec. TBR=reed Already agreed that moving is good. Committed: https://skia.googlesource.com/skia/+/9d55297f1fd1ed0f74277fd95b4c59608220aa77 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/9d55297f1fd1ed0f74277fd95b4c59608220aa77 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
