Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1672113002:
Roll ANGLE 7718c05..af344a1 (Closed)
|
Created:
4 years, 10 months ago by Jamie Madill Modified:
4 years, 10 months ago Reviewers:
Geoff Lang CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll ANGLE 7718c05..af344a1
https://chromium.googlesource.com/angle/angle.git/+log/7718c05..af344a1
BUG=580045, 522967
TBR=geofflang@chromium.org
TEST=bots
Committed: https://crrev.com/983dfbb3ada303cd671b304e1f68fff46d4da897
Cr-Commit-Position: refs/heads/master@{#373994}
Patch Set 1 #Messages
Total messages: 13 (7 generated)
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672113002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Roll ANGLE 7718c05..af344a1 https://chromium.googlesource.com/angle/angle.git/+log/7718c05..af344a1 BUG=580045,522967 TEST=bots ========== to ========== Roll ANGLE 7718c05..af344a1 https://chromium.googlesource.com/angle/angle.git/+log/7718c05..af344a1 BUG=580045,522967 TBR=geofflang@chromium.org TEST=bots ==========
jmadill@chromium.org changed reviewers: + geofflang@chromium.org
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672113002/1
Message was sent while issue was closed.
Description was changed from ========== Roll ANGLE 7718c05..af344a1 https://chromium.googlesource.com/angle/angle.git/+log/7718c05..af344a1 BUG=580045,522967 TBR=geofflang@chromium.org TEST=bots ========== to ========== Roll ANGLE 7718c05..af344a1 https://chromium.googlesource.com/angle/angle.git/+log/7718c05..af344a1 BUG=580045,522967 TBR=geofflang@chromium.org TEST=bots ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll ANGLE 7718c05..af344a1 https://chromium.googlesource.com/angle/angle.git/+log/7718c05..af344a1 BUG=580045,522967 TBR=geofflang@chromium.org TEST=bots ========== to ========== Roll ANGLE 7718c05..af344a1 https://chromium.googlesource.com/angle/angle.git/+log/7718c05..af344a1 BUG=580045,522967 TBR=geofflang@chromium.org TEST=bots Committed: https://crrev.com/983dfbb3ada303cd671b304e1f68fff46d4da897 Cr-Commit-Position: refs/heads/master@{#373994} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/983dfbb3ada303cd671b304e1f68fff46d4da897 Cr-Commit-Position: refs/heads/master@{#373994}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1679613002/ by thakis@chromium.org. The reason for reverting is: FAILED: ninja -t msvc -e environment.x86 -- "..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m32 /nologo /showIncludes /FC @obj\third_party\angle\src\tests\egl_tests\angle_end2end_tests.EGLPresentPathD3D11Test.obj.rsp /c ..\..\third_party\angle\src\tests\egl_tests\EGLPresentPathD3D11Test.cpp /Foobj\third_party\angle\src\tests\egl_tests\angle_end2end_tests.EGLPresentPathD3D11Test.obj /Fdobj\gpu\angle_end2end_tests.cc.pdb In file included from ..\..\third_party\angle\src\tests\egl_tests\EGLPresentPathD3D11Test.cpp:7: In file included from ..\..\third_party\angle\src\tests\test_utils/ANGLETest.h:13: ..\..\testing\gtest\include\gtest/gtest.h(1392,16) : error: comparison of integers of different signs: 'const int' and 'const unsigned int' [-Werror,-Wsign-compare] if (expected == actual) { ~~~~~~~~ ^ ~~~~~~ ..\..\testing\gtest\include\gtest/gtest.h(1422,12) : note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<int, unsigned int>' requested here return CmpHelperEQ(expected_expression, actual_expression, expected, ^ ..\..\third_party\angle\src\tests\egl_tests\EGLPresentPathD3D11Test.cpp(281,9) : note: in instantiation of function template specialization 'testing::internal::EqHelper<false>::Compare<int, unsigned int>' requested here ASSERT_EQ(mWindowWidth * 4, mappedSubresource.RowPitch); ^ ..\..\testing\gtest\include\gtest/gtest.h(1960,32) : note: expanded from macro 'ASSERT_EQ' # define ASSERT_EQ(val1, val2) GTEST_ASSERT_EQ(val1, val2) ^ ..\..\testing\gtest\include\gtest/gtest.h(1943,67) : note: expanded from macro 'GTEST_ASSERT_EQ' EqHelper<GTEST_IS_NULL_LITERAL_(expected)>::Compare, \ ^ (see your win_clang_dbg try job). |
