content/browser/bluetooth/bluetooth_dispatcher_host.cc - Issue 1672103002: Pass the frame instead of the WebContents through RunBluetoothChooser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/bluetooth/bluetooth_dispatcher_host.cc

Issue 1672103002: Pass the frame instead of the WebContents through RunBluetoothChooser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@doc-bubble-lifetimes

Patch Set: Sync Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/bluetooth/bluetooth_dispatcher_host.cc

diff --git a/content/browser/bluetooth/bluetooth_dispatcher_host.cc b/content/browser/bluetooth/bluetooth_dispatcher_host.cc

index 481cdbab06183743dd655ab28613b73df8cfad95..8eb74ebaa844948f19f244d61d364b47a9a07484 100644

--- a/content/browser/bluetooth/bluetooth_dispatcher_host.cc

+++ b/content/browser/bluetooth/bluetooth_dispatcher_host.cc

@@ -1075,7 +1075,7 @@ void BluetoothDispatcherHost::OnRequestDeviceImpl(

WebContents::FromRenderFrameHost(render_frame_host)) {

if (WebContentsDelegate* delegate = web_contents->GetDelegate()) {

session->chooser = delegate->RunBluetoothChooser(

- web_contents, chooser_event_handler,

+ render_frame_host, chooser_event_handler,

render_frame_host->GetLastCommittedOrigin());

jam 2016/02/17 01:54:16 no need to give this last parameter since the call

Jeffrey Yasskin 2016/02/17 17:51:36 Oops, you're totally right. I've removed it. Thank

}

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | content/public/browser/web_contents_delegate.h » ('j') | no next file with comments »