src/ports/SkRemotableFontMgr_win_dw.cpp - Issue 1672063002: SkTArray to move when moving.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkRemotableFontMgr_win_dw.cpp

Issue 1672063002: SkTArray to move when moving. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Disable bad language extensions, fix existing code. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkRemotableFontMgr_win_dw.cpp

diff --git a/src/ports/SkRemotableFontMgr_win_dw.cpp b/src/ports/SkRemotableFontMgr_win_dw.cpp

index 6c021a1ca682333da801f1dff789a53c24538ae6..d20017331543bfb61ce752ea26e2ee5de239b7d9 100644

--- a/src/ports/SkRemotableFontMgr_win_dw.cpp

+++ b/src/ports/SkRemotableFontMgr_win_dw.cpp

@@ -32,10 +32,7 @@ private:

DataId() { }

- // This is actually a move!!!

- explicit DataId(DataId& that)

- : fLoader(that.fLoader), fKey(that.fKey), fKeySize(that.fKeySize)

- {

+ DataId(DataId&& that) : fLoader(that.fLoader), fKey(that.fKey), fKeySize(that.fKeySize) {

that.fLoader = nullptr;

that.fKey = nullptr;

SkDEBUGCODE(that.fKeySize = 0xFFFFFFFF;)

« no previous file with comments | « include/ports/SkFontMgr_indirect.h ('k') | no next file » | no next file with comments »