Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: fuzzer/go/fuzzcache/fuzzcache_test.go

Issue 1672033002: Deduplicate fuzz cases on the frontend before they are displayed. (Closed) Base URL: https://skia.googlesource.com/buildbot@remove-overview
Patch Set: merged upstream Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fuzzer/go/frontend/syncer/fuzz_syncer.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fuzzer/go/fuzzcache/fuzzcache_test.go
diff --git a/fuzzer/go/fuzzcache/fuzzcache_test.go b/fuzzer/go/fuzzcache/fuzzcache_test.go
index ef5cc103fc22b2113657fe31bb32a3e033f327ca..15963210e20ce0c9b2a1fc0908567ab1b1e29855 100644
--- a/fuzzer/go/fuzzcache/fuzzcache_test.go
+++ b/fuzzer/go/fuzzcache/fuzzcache_test.go
@@ -71,105 +71,21 @@ func deleteBeforeTest(t *testing.T) {
}
}
-func makeStacktrace(file, function string, line int) data.StackTrace {
- return data.StackTrace{
- Frames: []data.StackTraceFrame{
- {
- PackageName: "mock/package/",
- FileName: file,
- LineNumber: line,
- FunctionName: function,
- },
- },
- }
-}
-
var expectedFuzzNames = []string{"aaaa", "bbbb", "cccc", "dddd", "eeee", "ffff", "gggg"}
-var mockFlags = []string{"foo", "bar"}
-
-var mockPictureDetails = map[string]data.FuzzReport{
- "aaaa": data.FuzzReport{
- DebugStackTrace: makeStacktrace("alpha", "beta", 16),
- ReleaseStackTrace: makeStacktrace("alpha", "beta", 16),
- DebugFlags: mockFlags,
- FuzzName: "aaaa",
- FuzzCategory: "skpicture",
- },
- "bbbb": data.FuzzReport{
- DebugStackTrace: makeStacktrace("alpha", "beta", 16),
- ReleaseStackTrace: data.StackTrace{},
- DebugFlags: mockFlags,
- FuzzName: "bbbb",
- FuzzCategory: "skpicture",
- },
- "cccc": data.FuzzReport{
- DebugStackTrace: makeStacktrace("alpha", "beta", 16),
- ReleaseStackTrace: makeStacktrace("alpha", "gamma", 26),
- DebugFlags: mockFlags,
- FuzzName: "cccc",
- FuzzCategory: "skpicture",
- },
- "dddd": data.FuzzReport{
- DebugStackTrace: makeStacktrace("alpha", "gamma", 43),
- ReleaseStackTrace: makeStacktrace("delta", "epsilon", 125),
- DebugFlags: mockFlags,
- FuzzName: "dddd",
- FuzzCategory: "skpicture",
- },
- "eeee": data.FuzzReport{
- DebugStackTrace: data.StackTrace{},
- ReleaseStackTrace: data.StackTrace{},
- DebugFlags: mockFlags,
- FuzzName: "eeee",
- FuzzCategory: "skpicture",
- },
- "ffff": data.FuzzReport{
- DebugStackTrace: makeStacktrace("alpha", "beta", 16),
- ReleaseStackTrace: makeStacktrace("alpha", "beta", 16),
- DebugFlags: mockFlags,
- FuzzName: "ffff",
- FuzzCategory: "skpicture",
- },
- "gggg": data.FuzzReport{
- DebugStackTrace: makeStacktrace("delta", "epsilon", 122),
- ReleaseStackTrace: data.StackTrace{},
- DebugFlags: mockFlags,
- FuzzName: "gggg",
- FuzzCategory: "skpicture",
- },
-}
-
-var mockAPIDetails = map[string]data.FuzzReport{
- "hhhh": data.FuzzReport{
- DebugStackTrace: makeStacktrace("alpha", "beta", 16),
- ReleaseStackTrace: makeStacktrace("alpha", "beta", 16),
- DebugFlags: mockFlags,
- FuzzName: "hhhh",
- FuzzCategory: "api",
- },
- "iiii": data.FuzzReport{
- DebugStackTrace: makeStacktrace("alpha", "beta", 16),
- ReleaseStackTrace: data.StackTrace{},
- DebugFlags: mockFlags,
- FuzzName: "iiii",
- FuzzCategory: "api",
- },
-}
-
var expectedPictureTree = data.FuzzReportTree{
data.FileFuzzReport{
FileName: "mock/package/alpha", Count: 4, Functions: []data.FunctionFuzzReport{
data.FunctionFuzzReport{
FunctionName: "beta", Count: 3, LineNumbers: []data.LineFuzzReport{
data.LineFuzzReport{
- LineNumber: 16, Count: 3, Details: []data.FuzzReport{mockPictureDetails["aaaa"], mockPictureDetails["bbbb"], mockPictureDetails["ffff"]},
+ LineNumber: 16, Count: 3, Details: []data.FuzzReport{data.MockReport("skpicture", "aaaa"), data.MockReport("skpicture", "bbbb"), data.MockReport("skpicture", "ffff")},
},
},
}, data.FunctionFuzzReport{
FunctionName: "gamma", Count: 1, LineNumbers: []data.LineFuzzReport{
data.LineFuzzReport{
- LineNumber: 26, Count: 1, Details: []data.FuzzReport{mockPictureDetails["cccc"]},
+ LineNumber: 26, Count: 1, Details: []data.FuzzReport{data.MockReport("skpicture", "cccc")},
},
},
},
@@ -180,10 +96,10 @@ var expectedPictureTree = data.FuzzReportTree{
data.FunctionFuzzReport{
FunctionName: "epsilon", Count: 2, LineNumbers: []data.LineFuzzReport{
data.LineFuzzReport{
- LineNumber: 122, Count: 1, Details: []data.FuzzReport{mockPictureDetails["gggg"]},
+ LineNumber: 122, Count: 1, Details: []data.FuzzReport{data.MockReport("skpicture", "gggg")},
},
data.LineFuzzReport{
- LineNumber: 125, Count: 1, Details: []data.FuzzReport{mockPictureDetails["dddd"]},
+ LineNumber: 125, Count: 1, Details: []data.FuzzReport{data.MockReport("skpicture", "dddd")},
},
},
},
@@ -194,7 +110,7 @@ var expectedPictureTree = data.FuzzReportTree{
data.FunctionFuzzReport{
FunctionName: common.UNKNOWN_FUNCTION, Count: 1, LineNumbers: []data.LineFuzzReport{
data.LineFuzzReport{
- LineNumber: -1, Count: 1, Details: []data.FuzzReport{mockPictureDetails["eeee"]},
+ LineNumber: -1, Count: 1, Details: []data.FuzzReport{data.MockReport("skpicture", "eeee")},
},
},
},
@@ -208,7 +124,7 @@ var expectedAPITree = data.FuzzReportTree{
data.FunctionFuzzReport{
FunctionName: "beta", Count: 2, LineNumbers: []data.LineFuzzReport{
data.LineFuzzReport{
- LineNumber: 16, Count: 2, Details: []data.FuzzReport{mockAPIDetails["hhhh"], mockAPIDetails["iiii"]},
+ LineNumber: 16, Count: 2, Details: []data.FuzzReport{data.MockReport("api", "hhhh"), data.MockReport("api", "iiii")},
},
},
},
« no previous file with comments | « fuzzer/go/frontend/syncer/fuzz_syncer.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698