Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1672033002: Deduplicate fuzz cases on the frontend before they are displayed. (Closed)

Created:
4 years, 10 months ago by kjlubick
Modified:
4 years, 10 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@remove-overview
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Deduplicate fuzz cases on the frontend before they are displayed. The current algorithm looks at the top 4 stacktrace frames (not caring about line numbers) and the flags to determine unique instances. fuzzes with no stacktraces or the "Other" flag are automatically considered 'unique' Preliminary results show that this trims down the skpicture fuzzes from ~70k to ~500-1000 BUG=skia:4438 Committed: https://skia.googlesource.com/buildbot/+/b935386b36d9ac4be4eaced5a031c4bcdf2112e8

Patch Set 1 #

Patch Set 2 : merged upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -199 lines) Patch
A fuzzer/go/deduplicator/deduplicator.go View 1 chunk +62 lines, -0 lines 0 comments Download
A fuzzer/go/deduplicator/deduplicator_test.go View 1 chunk +200 lines, -0 lines 0 comments Download
A fuzzer/go/frontend/data/report_mock.go View 1 chunk +97 lines, -0 lines 0 comments Download
M fuzzer/go/frontend/data/report_test.go View 6 chunks +10 lines, -94 lines 0 comments Download
M fuzzer/go/frontend/data/stacktrace.go View 1 chunk +2 lines, -0 lines 0 comments Download
M fuzzer/go/frontend/data/stacktrace_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M fuzzer/go/frontend/data/testdata/parse-asan-single.asan View 1 chunk +2 lines, -2 lines 0 comments Download
M fuzzer/go/frontend/gsloader/gsloader.go View 7 chunks +28 lines, -10 lines 0 comments Download
M fuzzer/go/frontend/syncer/fuzz_syncer.go View 1 chunk +1 line, -1 line 0 comments Download
M fuzzer/go/fuzzcache/fuzzcache_test.go View 4 chunks +6 lines, -90 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (5 generated)
jcgregorio
lgtm
4 years, 10 months ago (2016-02-05 20:41:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672033002/20001
4 years, 10 months ago (2016-02-08 14:53:25 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 14:56:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/b935386b36d9ac4be4eaced5a031c4bcdf21...

Powered by Google App Engine
This is Rietveld 408576698