Mark/unmark orthogonal writing-mode roots when ancestors were changed

Mark/unmark orthogonal writing-mode roots when ancestors were changed

When the writing-mode of ancestors of an orthogonal writing-mode root
were changed, the orthogonal writing-mode root may no longer be
orthogonal to its parent. However, since the style of the orthogonal
writing-mode root was not changed, its styleDidChange() is not called
and thus FrameView fails to track it.

This patch checks children to mark or unmark as orthogonal roots when
the writing-mode was changed after they were created.

BUG=584185, 584210
Committed: https://crrev.com/e4af0377e510216707e1346bbb47a1789273321f
Cr-Commit-Position: refs/heads/master@{#374794}

[kojii, 2016-02-05 19:33:34]

Description was changed from

==========
WIP: Fix orthogonal writing-mode root marking when parent was changed

BUG=
==========

to

==========
WIP: Fix orthogonal writing-mode root marking when parent was changed

BUG=584185, 584210
==========

[kojii, 2016-02-05 19:45:19]

Description was changed from

==========
WIP: Fix orthogonal writing-mode root marking when parent was changed

BUG=584185, 584210
==========

to

==========
WIP: Fix orthogonal writing-mode root marking when parent was changed

When the writing-mode of the parent of an orthogonal writing-mode root
was changed, the orthogonal writing mode root may no longer be
orthogonal to its parent. However, since its styleDidChange() is not
called, FrameView may not be able to track such roots.

This patch fixes to mark or unmark such orthogonal writing-mode roots.
BUG=584185, 584210
==========

[kojii, 2016-02-08 03:48:42]

Description was changed from

==========
WIP: Fix orthogonal writing-mode root marking when parent was changed

When the writing-mode of the parent of an orthogonal writing-mode root
was changed, the orthogonal writing mode root may no longer be
orthogonal to its parent. However, since its styleDidChange() is not
called, FrameView may not be able to track such roots.

This patch fixes to mark or unmark such orthogonal writing-mode roots.
BUG=584185, 584210
==========

to

==========
Manage orthogonal writing-mode roots when ancestors were changed

When the writing-mode of ancestors of an orthogonal writing-mode root
was changed, the orthogonal writing-mode root may no longer be
orthogonal to its parent. However, since the writing-mode of the root
was not changed, its styleDidChange() is not called and thus FrameView
loses tracking it.

This patch checks children to mark or unmark as orthogonal roots.

Since styles are computed from top to down the tree, it checks
childNeedsStyleRecalc() to avoid unnecessary traversals of children.

BUG=584185, 584210
==========

[kojii, 2016-02-08 04:08:40]

Description was changed from

==========
Manage orthogonal writing-mode roots when ancestors were changed

When the writing-mode of ancestors of an orthogonal writing-mode root
was changed, the orthogonal writing-mode root may no longer be
orthogonal to its parent. However, since the writing-mode of the root
was not changed, its styleDidChange() is not called and thus FrameView
loses tracking it.

This patch checks children to mark or unmark as orthogonal roots.

Since styles are computed from top to down the tree, it checks
childNeedsStyleRecalc() to avoid unnecessary traversals of children.

BUG=584185, 584210
==========

to

==========
Manage orthogonal writing-mode roots when ancestors were changed

When the writing-mode of ancestors of an orthogonal writing-mode root
were changed, the orthogonal writing-mode root may no longer be
orthogonal to its parent. However, since the style of the orthogonal
writing-mode root was not changed, its styleDidChange() is not called
and thus FrameView loses tracking it.

This patch checks children to mark or unmark as orthogonal roots when
the writing-mode was changed.

Since styles are computed from top to down the tree, it checks
childNeedsStyleRecalc() to avoid unnecessary traversals of children.

BUG=584185, 584210
==========

[kojii, 2016-02-08 08:12:15]

Description was changed from

==========
Manage orthogonal writing-mode roots when ancestors were changed

When the writing-mode of ancestors of an orthogonal writing-mode root
were changed, the orthogonal writing-mode root may no longer be
orthogonal to its parent. However, since the style of the orthogonal
writing-mode root was not changed, its styleDidChange() is not called
and thus FrameView loses tracking it.

This patch checks children to mark or unmark as orthogonal roots when
the writing-mode was changed.

Since styles are computed from top to down the tree, it checks
childNeedsStyleRecalc() to avoid unnecessary traversals of children.

BUG=584185, 584210
==========

to

==========
Manage orthogonal writing-mode roots when ancestors were changed

When the writing-mode of ancestors of an orthogonal writing-mode root
were changed, the orthogonal writing-mode root may no longer be
orthogonal to its parent. However, since the style of the orthogonal
writing-mode root was not changed, its styleDidChange() is not called
and thus FrameView fails to track it.

This patch checks children to mark or unmark as orthogonal roots when
the writing-mode was changed.

Since styles are computed from top to down the tree, it checks
childNeedsStyleRecalc() to avoid unnecessary traversals of children.

BUG=584185, 584210
==========

[kojii, 2016-02-08 08:15:21]

kojii@chromium.org changed reviewers:
+ leviw@chromium.org

[kojii, 2016-02-08 08:15:21]

PTAL. I couldn't find a way to fix this without enumerating children. I tried to
minimize the enumeration though.

If this is going to be really a perf hit, I could keep a HashSet of parents of
orthogonal roots, but managing a parent list won't be cheap for removal cases,
and for now it looks overkill to me.

WDYT?

[kojii, 2016-02-09 16:31:59]

Description was changed from

==========
Manage orthogonal writing-mode roots when ancestors were changed

When the writing-mode of ancestors of an orthogonal writing-mode root
were changed, the orthogonal writing-mode root may no longer be
orthogonal to its parent. However, since the style of the orthogonal
writing-mode root was not changed, its styleDidChange() is not called
and thus FrameView fails to track it.

This patch checks children to mark or unmark as orthogonal roots when
the writing-mode was changed.

Since styles are computed from top to down the tree, it checks
childNeedsStyleRecalc() to avoid unnecessary traversals of children.

BUG=584185, 584210
==========

to

==========
Mark/unmark orthogonal writing-mode roots when ancestors were changed

When the writing-mode of ancestors of an orthogonal writing-mode root
were changed, the orthogonal writing-mode root may no longer be
orthogonal to its parent. However, since the style of the orthogonal
writing-mode root was not changed, its styleDidChange() is not called
and thus FrameView fails to track it.

This patch checks children to mark or unmark as orthogonal roots when
the writing-mode was changed.

Since styles are computed from top to down the tree, it checks
childNeedsStyleRecalc() to avoid unnecessary traversals of children.

BUG=584185, 584210
==========

[kojii, 2016-02-10 04:48:36]

Description was changed from

==========
Mark/unmark orthogonal writing-mode roots when ancestors were changed

When the writing-mode of ancestors of an orthogonal writing-mode root
were changed, the orthogonal writing-mode root may no longer be
orthogonal to its parent. However, since the style of the orthogonal
writing-mode root was not changed, its styleDidChange() is not called
and thus FrameView fails to track it.

This patch checks children to mark or unmark as orthogonal roots when
the writing-mode was changed.

Since styles are computed from top to down the tree, it checks
childNeedsStyleRecalc() to avoid unnecessary traversals of children.

BUG=584185, 584210
==========

to

==========
Mark/unmark orthogonal writing-mode roots when ancestors were changed

When the writing-mode of ancestors of an orthogonal writing-mode root
were changed, the orthogonal writing-mode root may no longer be
orthogonal to its parent. However, since the style of the orthogonal
writing-mode root was not changed, its styleDidChange() is not called
and thus FrameView fails to track it.

This patch checks children to mark or unmark as orthogonal roots when
the writing-mode was changed after they were created.


BUG=584185, 584210
==========

[kojii, 2016-02-10 04:53:09]

The optimization using childNeedsStyleRecalc() was a bad idea, since it's also
set when other properties are changed.

Now, changing writing-mode of an element with a large number of children is a
bit expensive. I believe it's rare enough to go ahead and work later if needed,
but I'd appreciate your thoughts.

[kojii, 2016-02-10 06:26:15]

kojii@chromium.org changed reviewers:
+ ojan@chromium.org

[kojii, 2016-02-10 23:45:44]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2016-02-10 23:45:44]

Sorry to ask multiple times but crbug.com/584185#c9 is asking to revert once if
this takes long to land. Should have land when we're not moving across the
world, sorry about that.

[eae, 2016-02-10 23:48:08]

LGTM

[kojii, 2016-02-10 23:51:29]

Thank you!

[kojii, 2016-02-10 23:51:32]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-02-10 23:53:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672003002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672003002/60001

[commit-bot: I haz the power, 2016-02-11 00:00:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-16 22:32:56]

Description was changed from

==========
Mark/unmark orthogonal writing-mode roots when ancestors were changed

When the writing-mode of ancestors of an orthogonal writing-mode root
were changed, the orthogonal writing-mode root may no longer be
orthogonal to its parent. However, since the style of the orthogonal
writing-mode root was not changed, its styleDidChange() is not called
and thus FrameView fails to track it.

This patch checks children to mark or unmark as orthogonal roots when
the writing-mode was changed after they were created.


BUG=584185, 584210
==========

to

==========
Mark/unmark orthogonal writing-mode roots when ancestors were changed

When the writing-mode of ancestors of an orthogonal writing-mode root
were changed, the orthogonal writing-mode root may no longer be
orthogonal to its parent. However, since the style of the orthogonal
writing-mode root was not changed, its styleDidChange() is not called
and thus FrameView fails to track it.

This patch checks children to mark or unmark as orthogonal roots when
the writing-mode was changed after they were created.

BUG=584185, 584210

Committed: https://crrev.com/e4af0377e510216707e1346bbb47a1789273321f
Cr-Commit-Position: refs/heads/master@{#374794}
==========

[commit-bot: I haz the power, 2016-02-16 22:32:56]

Patchset 4 (id:??) landed as
https://crrev.com/e4af0377e510216707e1346bbb47a1789273321f
Cr-Commit-Position: refs/heads/master@{#374794}