Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 1671943003: Use system timestamp as capture timestamp (Closed)

Created:
4 years, 10 months ago by qiangchen
Modified:
4 years, 10 months ago
Reviewers:
DaleCurtis, pbos
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use system timestamp as capture timestamp For rendering smoothness, we used camera timestamp as capture timestamp, but if the clockrate of the camera is different from the system clock, it will make audio-video out of sync. So we change it back so far. This CL is essentially a revert of https://codereview.chromium.org/1324683004/ https://codereview.chromium.org/1421583007/ P.S. An ideal solution is that we should take in camera timestamp, but smoothly aligned with system clock. But at this point, we should make a quick CL to resolve this issue. BUG=584015 Committed: https://crrev.com/8e0974d2b27ab55a8df948b86804bf0f11c036e2 Cr-Commit-Position: refs/heads/master@{#373966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M media/capture/video/mac/video_capture_device_mac.mm View 1 chunk +1 line, -11 lines 0 comments Download
M media/capture/video/win/video_capture_device_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
qiangchen
4 years, 10 months ago (2016-02-05 23:52:23 UTC) #5
qiangchen
PTAL. It should be fixed asap.
4 years, 10 months ago (2016-02-05 23:59:42 UTC) #7
DaleCurtis
lgtm
4 years, 10 months ago (2016-02-06 00:07:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671943003/1
4 years, 10 months ago (2016-02-06 00:17:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-06 00:25:53 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8e0974d2b27ab55a8df948b86804bf0f11c036e2 Cr-Commit-Position: refs/heads/master@{#373966}
4 years, 10 months ago (2016-02-06 00:28:33 UTC) #14
pbos
lgtm
4 years, 10 months ago (2016-02-06 13:15:28 UTC) #15
qiangchen
4 years, 9 months ago (2016-03-10 20:54:02 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1783603004/ by qiangchen@chromium.org.

The reason for reverting is: WebRTC part of the issue has been fixed.
Thus we can reland the camera timestamp CL..

Powered by Google App Engine
This is Rietveld 408576698