Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: content/browser/renderer_host/render_process_host_impl.h

Issue 1671933002: Create and pass shared-histogram-allocator from browser to renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hsm-merge
Patch Set: fixed test to not use SharedMemory which doesn't work on all builds (and rebased) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/histogram_controller.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_process_host_impl.h
diff --git a/content/browser/renderer_host/render_process_host_impl.h b/content/browser/renderer_host/render_process_host_impl.h
index 7580068dff19cda345e3087b6a0e029e7ebf2f96..870227cab616327b9efcb1fa2e9b33383f5f1218 100644
--- a/content/browser/renderer_host/render_process_host_impl.h
+++ b/content/browser/renderer_host/render_process_host_impl.h
@@ -158,6 +158,8 @@ class CONTENT_EXPORT RenderProcessHostImpl
void ResumeDeferredNavigation(const GlobalRequestID& request_id) override;
void NotifyTimezoneChange(const std::string& timezone) override;
ServiceRegistry* GetServiceRegistry() override;
+ scoped_ptr<base::SharedPersistentMemoryAllocator> TakeMetricsAllocator()
+ override;
const base::TimeTicks& GetInitTimeForNavigationMetrics() const override;
bool SubscribeUniformEnabled() const override;
void OnAddSubscription(unsigned int target) override;
@@ -331,6 +333,12 @@ class CONTENT_EXPORT RenderProcessHostImpl
// change.
void UpdateProcessPriority();
+ // Creates a PersistentMemoryAllocator and shares it with the renderer
+ // process for it to store histograms from that process. The allocator is
+ // available for extraction by a SubprocesMetricsProvider in order to
+ // report those histograms to UMA.
+ void CreateSharedRendererHistogramAllocator();
+
// Handle termination of our process.
void ProcessDied(bool already_dead, RendererClosedDetails* known_details);
@@ -509,6 +517,9 @@ class CONTENT_EXPORT RenderProcessHostImpl
// Whether or not the CHROMIUM_subscribe_uniform WebGL extension is enabled
bool subscribe_uniform_enabled_;
+ // The memory allocator, if any, in which the renderer will write its metrics.
+ scoped_ptr<base::SharedPersistentMemoryAllocator> metrics_allocator_;
+
bool channel_connected_;
bool sent_render_process_ready_;
« no previous file with comments | « content/browser/histogram_controller.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698