chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 1671933002: Create and pass shared-histogram-allocator from browser to renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 1671933002: Create and pass shared-histogram-allocator from browser to renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hsm-merge

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/metrics/persistent_histogram_allocator.h ('k') | chrome/browser/metrics/subprocess_metrics_provider.h » ('j') | chrome/browser/metrics/subprocess_metrics_provider_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index 5f19fb208767611839e209b866f63896a59cbd48..b95a528254b86bffe1baf9a3aff5d0304e89890c 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -24,6 +24,7 @@

#include "chrome/browser/google/google_brand.h"

#include "chrome/browser/metrics/chrome_stability_metrics_provider.h"

#include "chrome/browser/metrics/metrics_reporting_state.h"

+#include "chrome/browser/metrics/subprocess_metrics_provider.h"

#include "chrome/browser/metrics/time_ticks_experiment_win.h"

#include "chrome/browser/sync/chrome_sync_client.h"

#include "chrome/browser/ui/browser_otr_state.h"

@@ -357,6 +358,10 @@ void ChromeMetricsServiceClient::Initialize() {

metrics_service_.reset(new metrics::MetricsService(

metrics_state_manager_, this, g_browser_process->local_state()));

+ // Gets access to persistent metrics shared by sub-processes.

+ metrics_service_->RegisterMetricsProvider(

+ scoped_ptr<metrics::MetricsProvider>(new SubprocessMetricsProvider()));

// Register metrics providers.

#if defined(ENABLE_EXTENSIONS)

metrics_service_->RegisterMetricsProvider(