content/browser/histogram_controller.cc - Issue 1671933002: Create and pass shared-histogram-allocator from browser to renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/histogram_controller.cc

Issue 1671933002: Create and pass shared-histogram-allocator from browser to renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hsm-merge

Patch Set: addressed review comments by Alexei; fixed test on some builds Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/subprocess_metrics_provider_unittest.cc ('K') | « components/metrics/metrics_service.cc ('k') | content/browser/renderer_host/render_process_host_impl.h » ('j') | content/browser/renderer_host/render_process_host_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/histogram_controller.cc

diff --git a/content/browser/histogram_controller.cc b/content/browser/histogram_controller.cc

index efefa9645752a292380945ed59fcd69a4724cbc7..b81bda768af50a5b54302eaf05e04c19da82d611 100644

--- a/content/browser/histogram_controller.cc

+++ b/content/browser/histogram_controller.cc

@@ -90,8 +90,10 @@ void HistogramController::GetHistogramDataFromChildProcesses(

continue;

++pending_processes;

- if (!iter.Send(new ChildProcessMsg_GetChildHistogramData(sequence_number)))

+ if (!iter.Send(new ChildProcessMsg_GetChildNonPersistentHistogramData(

+ sequence_number))) {

--pending_processes;

+ }

}

BrowserThread::PostTask(

@@ -113,7 +115,8 @@ void HistogramController::GetHistogramData(int sequence_number) {

!it.IsAtEnd(); it.Advance()) {

++pending_processes;

if (!it.GetCurrentValue()->Send(

- new ChildProcessMsg_GetChildHistogramData(sequence_number))) {

+ new ChildProcessMsg_GetChildNonPersistentHistogramData(

+ sequence_number))) {

--pending_processes;

}