content/common/child_process_messages.h - Issue 1671933002: Create and pass shared-histogram-allocator from browser to renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/child_process_messages.h

Issue 1671933002: Create and pass shared-histogram-allocator from browser to renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hsm-merge

Patch Set: addressd review comments by Alexei Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_process_host_impl.cc ('K') | « content/child/child_histogram_message_filter.cc ('k') | content/public/browser/render_process_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/child_process_messages.h

diff --git a/content/common/child_process_messages.h b/content/common/child_process_messages.h

index 9476f1a5163504c4ce7a4eff46f3016a48cf6055..4918e598a427db01428a365753797502f36877e5 100644

--- a/content/common/child_process_messages.h

+++ b/content/common/child_process_messages.h

@@ -101,8 +101,16 @@ IPC_MESSAGE_CONTROL2(ChildProcessMsg_GetChildProfilerData,

IPC_MESSAGE_CONTROL1(ChildProcessMsg_ProfilingPhaseCompleted,

int /* profiling_phase */)

+// Sent to set the shared memory buffer to be used for storing histograms that

+// are to be reported by the browser process to UMA. The following message

+// (GetChildHistogramData) will return any histograms created before this

+// message is received but not any histograms created afterward.

+IPC_MESSAGE_CONTROL2(ChildProcessMsg_SetHistogramMemory,

+ base::SharedMemoryHandle /* shm_handle */,

+ int /* shm_size */)

// Send to all the child processes to send back histogram data.

-IPC_MESSAGE_CONTROL1(ChildProcessMsg_GetChildHistogramData,

+IPC_MESSAGE_CONTROL1(ChildProcessMsg_GetChildNonPersistentHistogramData,

int /* sequence_number */)

// Sent to child processes to tell them to enter or leave background mode.