Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1710)

Unified Diff: runtime/bin/eventhandler_linux.h

Issue 167193004: Remove 'mask' from SocketData, as it's not required. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Simplify Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/eventhandler_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/eventhandler_linux.h
diff --git a/runtime/bin/eventhandler_linux.h b/runtime/bin/eventhandler_linux.h
index b4a9f604247f33f1599e8d518530e2726471d9b9..7f2ee25518f7e6b55a45e738b5d511b5dcaea58d 100644
--- a/runtime/bin/eventhandler_linux.h
+++ b/runtime/bin/eventhandler_linux.h
@@ -31,7 +31,7 @@ class InterruptMessage {
class SocketData {
public:
explicit SocketData(intptr_t fd)
- : tracked_by_epoll_(false), fd_(fd), port_(0), mask_(0) {
+ : tracked_by_epoll_(false), fd_(fd), port_(0) {
ASSERT(fd_ != -1);
}
@@ -45,23 +45,17 @@ class SocketData {
void Close() {
port_ = 0;
- mask_ = 0;
close(fd_);
fd_ = -1;
}
- bool IsListeningSocket() { return (mask_ & (1 << kListeningSocket)) != 0; }
- bool IsPipe() { return (mask_ & (1 << kPipe)) != 0; }
-
- void SetPortAndMask(Dart_Port port, intptr_t mask) {
+ void SetPort(Dart_Port port) {
ASSERT(fd_ != -1);
port_ = port;
- mask_ = mask;
}
intptr_t fd() { return fd_; }
Dart_Port port() { return port_; }
- intptr_t mask() { return mask_; }
bool tracked_by_epoll() { return tracked_by_epoll_; }
void set_tracked_by_epoll(bool value) { tracked_by_epoll_ = value; }
« no previous file with comments | « no previous file | runtime/bin/eventhandler_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698