Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1671903002: [Telemetry] Implement network_controller_backend new API (Closed)

Created:
4 years, 10 months ago by perezju
Modified:
4 years, 10 months ago
Reviewers:
eakuefner, nednguyen
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Implement network_controller_backend new API This CL implements the methods needed for the network_controller_backend API, namely: - Open/Close - StartReplay/StopReplay Also retains the old API, whose implementation is temporarily replaced with wrappers around the new API methods. Follow up CLs will switch clients to the new API and, eventually, remove the old deprecated methods when no longer used. BUG=catapult:#1977 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d626256aa0401398f84ea158f36dfd540721381e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+497 lines, -359 lines) Patch
M telemetry/telemetry/internal/forwarders/__init__.py View 1 chunk +23 lines, -1 line 0 comments Download
M telemetry/telemetry/internal/platform/network_controller_backend.py View 2 chunks +208 lines, -155 lines 0 comments Download
M telemetry/telemetry/internal/platform/network_controller_backend_unittest.py View 1 chunk +263 lines, -201 lines 0 comments Download
M telemetry/telemetry/internal/util/webpagereplay.py View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
perezju
My previous CL was getting a bit out of hand and, because I had to ...
4 years, 10 months ago (2016-02-05 15:27:17 UTC) #2
nednguyen
lgtm This looks great!
4 years, 10 months ago (2016-02-05 16:12:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671903002/1
4 years, 10 months ago (2016-02-08 10:01:27 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 10:11:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698