Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1671883002: [tools] making the ic-explorer drilldown recursive (Closed)

Created:
4 years, 10 months ago by Camillo Bruni
Modified:
4 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] improve the ic-explorer - drilldown lazy and recursive - improve parsing NOTRY=true Committed: https://crrev.com/709be02b9f2a3c9d97ec5bc8e83ab3578a6a78ba Cr-Commit-Position: refs/heads/master@{#33774}

Patch Set 1 #

Patch Set 2 : renaming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -379 lines) Patch
M tools/ICE.html View 1 1 chunk +0 lines, -300 lines 0 comments Download
A + tools/ic-explorer.html View 1 10 chunks +117 lines, -79 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Camillo Bruni
4 years, 10 months ago (2016-02-05 12:54:09 UTC) #3
Jakob Kummerow
rubberstamp LGTM. I'd recommend to keep lines to 80 columns, but I don't care much.
4 years, 10 months ago (2016-02-05 13:02:25 UTC) #4
Jakob Kummerow
I put NOTRY=true, no need to waste try bot resources on this.
4 years, 10 months ago (2016-02-05 13:10:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671883002/20001
4 years, 10 months ago (2016-02-05 13:10:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-05 13:19:39 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 13:19:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/709be02b9f2a3c9d97ec5bc8e83ab3578a6a78ba
Cr-Commit-Position: refs/heads/master@{#33774}

Powered by Google App Engine
This is Rietveld 408576698