Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1671823002: Restrict the types of nodes that could be assigned to a slot. (Closed)

Created:
4 years, 10 months ago by hayato
Modified:
4 years, 10 months ago
Reviewers:
tkent, kochi
CC:
chromium-reviews, blink-reviews-html_chromium.org, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restrict the types of nodes that could be assigned to a slot. The spec change is: https://github.com/w3c/webcomponents/issues/351 BUG=531990 Committed: https://crrev.com/aa35fb84c80c0928afbc9d92660bb97d34b40fc4 Cr-Commit-Position: refs/heads/master@{#374099}

Patch Set 1 #

Patch Set 2 : wip #

Patch Set 3 : rebased #

Messages

Total messages: 26 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671823002/1
4 years, 10 months ago (2016-02-05 07:44:56 UTC) #2
hayato
wip
4 years, 10 months ago (2016-02-05 07:51:09 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671823002/20001
4 years, 10 months ago (2016-02-05 07:51:35 UTC) #5
hayato
PTAL
4 years, 10 months ago (2016-02-05 08:05:11 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176877) win_chromium_rel_ng on ...
4 years, 10 months ago (2016-02-05 09:04:08 UTC) #9
hayato
Let me fix failing tests.
4 years, 10 months ago (2016-02-05 09:49:15 UTC) #10
hayato
rebased
4 years, 10 months ago (2016-02-05 10:06:45 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671823002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671823002/40001
4 years, 10 months ago (2016-02-05 10:07:05 UTC) #13
hayato
PTAL
4 years, 10 months ago (2016-02-05 10:35:32 UTC) #14
kochi
lgtm
4 years, 10 months ago (2016-02-05 10:44:17 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-05 12:05:06 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671823002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671823002/40001
4 years, 10 months ago (2016-02-08 01:02:26 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/142123)
4 years, 10 months ago (2016-02-08 02:31:10 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671823002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671823002/40001
4 years, 10 months ago (2016-02-08 08:17:32 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-08 11:50:41 UTC) #24
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 11:51:42 UTC) #26
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/aa35fb84c80c0928afbc9d92660bb97d34b40fc4
Cr-Commit-Position: refs/heads/master@{#374099}

Powered by Google App Engine
This is Rietveld 408576698