Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: src/heap/heap.cc

Issue 1671813003: [interpreter] move the dispatch table off heap. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index 4f09e675414c4d5e35d014f86273a08faef747ef..87d5e6ec2ae3549b03c81f3844f520912c6878dc 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -2878,11 +2878,6 @@ void Heap::CreateInitialObjects() {
set_noscript_shared_function_infos(Smi::FromInt(0));
- // Will be filled in by Interpreter::Initialize().
- set_interpreter_table(
- *interpreter::Interpreter::CreateUninitializedInterpreterTable(
- isolate()));
-
// Initialize keyed lookup cache.
isolate_->keyed_lookup_cache()->Clear();
@@ -4612,8 +4607,10 @@ void Heap::IterateStrongRoots(ObjectVisitor* v, VisitMode mode) {
// on scavenge collections.
if (mode != VISIT_ALL_IN_SCAVENGE) {
isolate_->builtins()->IterateBuiltins(v);
+ v->Synchronize(VisitorSynchronization::kBuiltins);
+ isolate_->interpreter()->IterateDispatchTable(v);
+ v->Synchronize(VisitorSynchronization::kDispatchTable);
}
- v->Synchronize(VisitorSynchronization::kBuiltins);
// Iterate over global handles.
switch (mode) {

Powered by Google App Engine
This is Rietveld 408576698