[interpreter] move the dispatch table off heap.

[interpreter] move the dispatch table off heap.

This makes the dispatch table similar to the builtins code list and makes
sure that the dispatch table does not move.

R=mstarzinger@chromium.org, rmcilroy@chromium.org

Committed: https://crrev.com/91009c50951efc6ba62b46800d5d8567c3b72fff
Cr-Commit-Position: refs/heads/master@{#33781}

[Yang, 2016-02-05 10:59:21]

Hannes, fyi this adds another off-heap list of objects that needs to be visited
when iterating strong roots.

[Michael Starzinger, 2016-02-05 11:42:16]

LGTM from my end. Feel free to do the ports. Please wait for sign-off from Ross
before landing.

https://codereview.chromium.org/1671813003/diff/1/src/assembler.h
File src/assembler.h (right):

https://codereview.chromium.org/1671813003/diff/1/src/assembler.h#newcode897
src/assembler.h:897: static ExternalReference
interpreter_dispatch_table_address(Isolate* isolate);
nit: Move to below the general comment about "One-of-a-kind referneces" below.

https://codereview.chromium.org/1671813003/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):

https://codereview.chromium.org/1671813003/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:25: for (int i = 0; i < kDispatchTableSize; i++)
dispatch_table_[i] = nullptr;
nit: memset(&dispatch_table_, 0, sizeof(dispatch_table_));

[Yang, 2016-02-05 11:51:01]

Addressed Michael's comments. Added ports.

https://codereview.chromium.org/1671813003/diff/1/src/assembler.h
File src/assembler.h (right):

https://codereview.chromium.org/1671813003/diff/1/src/assembler.h#newcode897
src/assembler.h:897: static ExternalReference
interpreter_dispatch_table_address(Isolate* isolate);
On 2016/02/05 11:42:16, Michael Starzinger wrote:
> nit: Move to below the general comment about "One-of-a-kind referneces" below.

Done.

https://codereview.chromium.org/1671813003/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):

https://codereview.chromium.org/1671813003/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:25: for (int i = 0; i < kDispatchTableSize; i++)
dispatch_table_[i] = nullptr;
On 2016/02/05 11:42:16, Michael Starzinger wrote:
> nit: memset(&dispatch_table_, 0, sizeof(dispatch_table_));

Done.

[rmcilroy, 2016-02-05 12:11:18]

lgtm, thanks!

[Yang, 2016-02-05 12:12:26]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-02-05 12:12:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1671813003/#ps60001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-02-05 12:12:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1671813003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1671813003/60001

[commit-bot: I haz the power, 2016-02-05 13:17:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 13:17:06]

Try jobs failed on following builders:
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/997)
  v8_linux_dbg_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[Yang, 2016-02-05 13:56:52]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-02-05 13:56:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1671813003/#ps80001
(title: "fix verify heap")

[commit-bot: I haz the power, 2016-02-05 13:56:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1671813003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1671813003/80001

[commit-bot: I haz the power, 2016-02-05 14:32:44]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-05 14:33:20]

Description was changed from

==========
[interpreter] move the dispatch table off heap.

This makes the dispatch table similar to the builtins code list and makes
sure that the dispatch table does not move.

R=mstarzinger@chromium.org, rmcilroy@chromium.org
==========

to

==========
[interpreter] move the dispatch table off heap.

This makes the dispatch table similar to the builtins code list and makes
sure that the dispatch table does not move.

R=mstarzinger@chromium.org, rmcilroy@chromium.org

Committed: https://crrev.com/91009c50951efc6ba62b46800d5d8567c3b72fff
Cr-Commit-Position: refs/heads/master@{#33781}
==========

[commit-bot: I haz the power, 2016-02-05 14:33:21]

Patchset 5 (id:??) landed as
https://crrev.com/91009c50951efc6ba62b46800d5d8567c3b72fff
Cr-Commit-Position: refs/heads/master@{#33781}