Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1671783002: X87: [generators] Implement Generator.prototype.return. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
Reviewers:
Weiliang, chunyang.dai, neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [generators] Implement Generator.prototype.return. port dbd86408134e67551c1e66c3a7484abb628b95f7 (r33744) original commit message: Note: This is currently only used by yield*, we still need to support it in other places (such as for-of loops). It can be used manually of course. (This CL does not touch the full-codegen implementation of yield* because that code is already dead. The yield* desugaring already supports return and doesn't need to be touched.) BUG= Committed: https://crrev.com/c357a87a79ce94d83443686bfd41c9c0a58936b5 Cr-Commit-Position: refs/heads/master@{#33760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 4 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-05 06:36:25 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-05 06:49:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671783002/1
4 years, 10 months ago (2016-02-05 07:24:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 07:41:09 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 07:41:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c357a87a79ce94d83443686bfd41c9c0a58936b5
Cr-Commit-Position: refs/heads/master@{#33760}

Powered by Google App Engine
This is Rietveld 408576698