components/autofill/core/common/form_data.h - Issue 1671753004: [Autofill] Fill fields that have an autocomplete attributes even if not in a form.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/form_data.h

Issue 1671753004: [Autofill] Fill fields that have an autocomplete attributes even if not in a form. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/form_structure_unittest.cc ('K') | « components/autofill/core/browser/form_structure_unittest.cc ('k') | components/autofill/core/common/form_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/form_data.h

diff --git a/components/autofill/core/common/form_data.h b/components/autofill/core/common/form_data.h

index a406ccbd3d2c70958df8187e20673a1c0f92cf5c..929019b0e82c22c2b5934c833bbc6cca7451fcdd 100644

--- a/components/autofill/core/common/form_data.h

+++ b/components/autofill/core/common/form_data.h

@@ -32,8 +32,11 @@ struct FormData {

GURL origin;

// The action target of the form.

GURL action;

- // true if this form is a form tag.

+ // True if this form is a form tag.

bool is_form_tag;

+ // True if the form is made of unowned fields in a non checkout flow. The

+ // fields should be filled using only the autocomplete attributes.

Mathieu 2016/02/05 22:36:45 nit: don't mention behavior.

sebsg 2016/02/09 01:13:57 Done.

+ bool is_formless_checkout;

// A vector of all the input fields in the form.

std::vector<FormFieldData> fields;

};