[Autofill] Fill fields that have an autocomplete attributes even if not in a form.

components/autofill/content/renderer/form_autofill_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/form_autofill_util.h"
 
 #include <map>
 #include <set>
 
 #include "base/command_line.h"
@@ skipping 1509 matching lines @@
                                  keyword, keyword + strlen(keyword));
     if (title_pos != title.end() ||
         path.find(keyword) != std::string::npos) {
       // Found a keyword: treat this as an unowned form.
       return UnownedFormElementsAndFieldSetsToFormData(
           fieldsets, control_elements, element, document, extract_mask, form,
           field);
     }
   }
 
-  return false;
+  // Since it's not a checkout flow, only add fields that have an autocomplete

[Mathieu, 2016/02/05 18:39:06]

*a non-"off" autocomplete attribute

[sebsg, 2016/02/05 20:08:00]

Done.

+  // attribute to the formless autofill.
+  std::vector<WebFormControlElement> elements_with_autocomplete;
+  for (const WebFormControlElement& element : control_elements) {
+    blink::WebString autocomplete = element.getAttribute("autocomplete");
+    if (autocomplete.utf8() != "" && autocomplete.utf8() != "off")

[Mathieu, 2016/02/05 18:39:06]

Other methods seem to define statics like so:

CR_DEFINE_STATIC_LOCAL(WebString, kRole, ("role"));

Perhaps you can use those for comparison?

[Mathieu, 2016/02/05 18:39:06]

if (autocomplete.length() && ...

[sebsg, 2016/02/05 20:08:00]

Done.

[sebsg, 2016/02/05 20:08:00]

Done.

+      elements_with_autocomplete.push_back(element);
+  }
+
+  if (elements_with_autocomplete.empty())
+    return false;
+
+  form->is_syntehtic_non_checkout_form = true;

[Mathieu, 2016/02/05 18:39:06]

Could we do only with a |non_checkout| attribute in combination with the
|is_form_tag|?

[sebsg, 2016/02/05 20:08:00]

Done.

+
+  return UnownedFormElementsAndFieldSetsToFormData(
+      fieldsets, elements_with_autocomplete, element, document, extract_mask,
+      form, field);
 }
 
 bool UnownedPasswordFormElementsAndFieldSetsToFormData(
     const std::vector<blink::WebElement>& fieldsets,
     const std::vector<blink::WebFormControlElement>& control_elements,
     const blink::WebFormControlElement* element,
     const blink::WebDocument& document,
     ExtractMask extract_mask,
     FormData* form,
     FormFieldData* field) {
@@ skipping 194 matching lines @@
     // Zero selection start is for password manager, which can show usernames
     // that do not begin with the user input value.
     selection_start = (offset == base::string16::npos) ? 0 : offset;
   }
 
   input_element->setSelectionRange(selection_start, suggestion.length());
 }
 
 }  // namespace form_util
 }  // namespace autofill