Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: src/compiler/interpreter-assembler.cc

Issue 1671653002: [Interpreter] Ensure StackCheck bytecode handler is in split-edge form. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove Fallthrough from RMA Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/interpreter-assembler.cc
diff --git a/src/compiler/interpreter-assembler.cc b/src/compiler/interpreter-assembler.cc
index 6c1b8bb32e7a91e9f7117a789c0b7685754447a6..88e9f3346a09e503ab2e85a5086a68f0f508e386 100644
--- a/src/compiler/interpreter-assembler.cc
+++ b/src/compiler/interpreter-assembler.cc
@@ -707,7 +707,7 @@ void InterpreterAssembler::DispatchTo(Node* new_bytecode_offset) {
}
void InterpreterAssembler::StackCheck() {
- RawMachineLabel ok, stack_guard;
+ RawMachineLabel end, ok, stack_guard;
Node* sp = raw_assembler_->LoadStackPointer();
Node* stack_limit = raw_assembler_->Load(
MachineType::Pointer(),
@@ -717,8 +717,10 @@ void InterpreterAssembler::StackCheck() {
raw_assembler_->Branch(condition, &ok, &stack_guard);
raw_assembler_->Bind(&stack_guard);
CallRuntime(Runtime::kStackGuard);
- raw_assembler_->Goto(&ok);
+ raw_assembler_->Goto(&end);
raw_assembler_->Bind(&ok);
+ raw_assembler_->Goto(&end);
+ raw_assembler_->Bind(&end);
}
void InterpreterAssembler::Abort(BailoutReason bailout_reason) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698