Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1671623005: [turbofan] Deprecate --turbo-try-finally flag. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Deprecate --turbo-try-finally flag. R=jarin@chromium.org Committed: https://crrev.com/8b4e1042ae53aa6ce4af649f39baf97229462ee1 Cr-Commit-Position: refs/heads/master@{#33786}

Patch Set 1 #

Patch Set 2 : Also enable test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-deopt.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 1 6 chunks +0 lines, -7 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
We don't need no off-switch where we are going. :)
4 years, 10 months ago (2016-02-05 14:25:45 UTC) #1
Jarin
lgtm!
4 years, 10 months ago (2016-02-05 15:06:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671623005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671623005/20001
4 years, 10 months ago (2016-02-05 15:11:44 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-05 15:20:36 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 15:20:48 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8b4e1042ae53aa6ce4af649f39baf97229462ee1
Cr-Commit-Position: refs/heads/master@{#33786}

Powered by Google App Engine
This is Rietveld 408576698