content/renderer/media/renderer_webmediaplayer_delegate.h - Issue 1671603002: Mute audio for Spitzer playbacks that haven't received focus yet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/renderer_webmediaplayer_delegate.h

Issue 1671603002: Mute audio for Spitzer playbacks that haven't received focus yet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/android/media_session_controller_unittest.cc ('k') | content/renderer/media/renderer_webmediaplayer_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/renderer_webmediaplayer_delegate.h

diff --git a/content/renderer/media/renderer_webmediaplayer_delegate.h b/content/renderer/media/renderer_webmediaplayer_delegate.h

index 6f2b5a33192ed25a99147f77f13406a42cb92696..20b86c8ee012170b5a5dc40a8ea22b19b793870b 100644

--- a/content/renderer/media/renderer_webmediaplayer_delegate.h

+++ b/content/renderer/media/renderer_webmediaplayer_delegate.h

@@ -53,6 +53,13 @@ class RendererWebMediaPlayerDelegate

void OnMediaDelegateVolumeMultiplierUpdate(int delegate_id,

double multiplier);

+ // For platforms which require playback focus approval this will initialize

+ // the volume multiplier to zero. It will be set correctly by the browser

+ // after playback is approved or the playback will be paused if not.

+ //

+ // Currently this is only done on Android.

+ void MuteObserverUntilPlaybackFocusApproved(int delegate_id);

bool has_played_media_ = false;

IDMap<Observer> id_map_;