Chromium Code Reviews Chromium Code Reviews
Issue
1671543002:
Reland of Update V8 to version 4.10.155. (Closed)
DescriptionReland of Update V8 to version 4.10.155. (patchset #1 id:1 of https://codereview.chromium.org/1666193002/ )
Reason for revert:
Compile went green already before the revert was in. Might have been a goma
problem? Or some incremental build issue? Speculatively relanding.
Original issue's description:
> Revert of Update V8 to version 4.10.155. (patchset #1 id:1 of https://codereview.chromium.org/1669813002/ )
>
> Reason for revert:
> Breaks compile on Android
>
> FAILED: /mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/Android_Builder/build/src/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/content/test/content_browser_test_support.content_browser_test_utils_internal.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DCR_CLANG_REVISION=259395-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_BROWSER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DDONT_EMBED_BUILD_METADATA -DFIELDTRIAL_TESTING_ENABLED -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_SUPERVISED_USERS=1 -DVIDEO_HOLE=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_WEBVR -DSAFE_BROWSING_DB_REMOTE -DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_BUILD_FOR_ANDROID -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DGTEST_USE_OWN_TR1_TUPLE=1 -DGTEST_HAS_TR1_TUPLE=1 -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DANDROID -D__GNU_SOURCE=1 '-DCHROME_BUILD_ID=""' -DHAVE_SYS_UIO_H -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../../third_party/khronos -I../../gpu -I../.. -I../../skia/config -Igen/angle -I../../third_party/WebKit/Source -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../testing/gtest/include -I../../third_party/WebKit -fstack-protector --param=ssp-buffer-size=4 -Werror -fno-strict-aliasing -Wall -Wno-extra -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-unused-local-typedefs -march=armv7-a -mtune=generic-armv7-a -mfpu=neon -mfloat-abi=softfp -mthumb -fno-tree-sra -fno-caller-saves -Wno-psabi -mthumb-interwork -ffunction-sections -funwind-tables -g -fstack-protector -fno-short-enums -finline-limit=64 --sysroot=../../third_party/android_tools/ndk//platforms/android-16/arch-arm -Os -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -funwind-tables -g0 -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wno-abi -std=gnu++11 -Wno-narrowing -isystem../../third_party/android_tools/ndk//sources/cxx-stl/llvm-libc++/libcxx/include -isystem../../third_party/android_tools/ndk//sources/cxx-stl/llvm-libc++abi/libcxxabi/include -isystem../../third_party/android_tools/ndk//sources/android/support/include -c ../../content/test/content_browser_test_utils_internal.cc -o obj/content/test/content_browser_test_support.content_browser_test_utils_internal.o
> In file included from ../../content/browser/frame_host/frame_tree_node.h:16:0,
> from ../../content/test/content_browser_test_utils_internal.cc:15:
> ../../content/browser/frame_host/render_frame_host_impl.h:34:68: fatal error: content/common/image_downloader/image_downloader.mojom.h: No such file or directory
> #include "content/common/image_downloader/image_downloader.mojom.h"
> ^
> compilation terminated.
> Note: Some input files use or override a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> ninja: build stopped: subcommand failed.
>
> Original issue's description:
> > Update V8 to version 4.10.155.
> >
> > Summary of changes available at:
> > https://chromium.googlesource.com/v8/v8/+log/d425d920..45528bd7
> >
> > Please follow these instructions for assigning/CC'ing issues:
> > https://github.com/v8/v8/wiki/Triaging%20issues
> >
> > Please close rolling in case of a roll revert:
> > https://v8-roll.appspot.com/
> > This only works with a Google account.
> >
> > TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
> >
> > Committed: https://crrev.com/0df18d057870a0524c1f50dc10256975929a7f58
> > Cr-Commit-Position: refs/heads/master@{#373552}
>
> TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/978a906f715792e4a5ee393042a58c43a1e93160
> Cr-Commit-Position: refs/heads/master@{#373556}
TBR=hablich@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org,megjablon@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/cd5121c3eaa07ad629bf3cbedf0345272f42812b
Cr-Commit-Position: refs/heads/master@{#373605}
Patch Set 1 #Messages
Total messages: 6 (2 generated)
|
