Refactor WebCore::DragImage.

Source/core/platform/DragImage.cpp

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
  * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
  */
 
 #include "config.h"
 #include "core/platform/DragImage.h"
 
+#include "core/platform/graphics/BitmapImage.h"
+#include "core/platform/graphics/Color.h"
+#include "core/platform/graphics/FloatPoint.h"
+#include "core/platform/graphics/FloatRect.h"
 #include "core/platform/graphics/Font.h"
 #include "core/platform/graphics/FontCache.h"
 #include "core/platform/graphics/FontDescription.h"
-#include "core/platform/graphics/FontSelector.h"
+#include "core/platform/graphics/FontMetrics.h"
 #include "core/platform/graphics/GraphicsContext.h"
+#include "core/platform/graphics/Image.h"
 #include "core/platform/graphics/ImageBuffer.h"
+#include "core/platform/graphics/IntPoint.h"
+#include "core/platform/graphics/IntSize.h"
 #include "core/platform/graphics/StringTruncator.h"
 #include "core/platform/graphics/TextRun.h"
+#include "core/platform/graphics/skia/NativeImageSkia.h"
+#include "core/platform/graphics/transforms/AffineTransform.h"
+#include "skia/ext/image_operations.h"
+#include "third_party/skia/include/core/SkCanvas.h"
+#include "third_party/skia/include/core/SkMatrix.h"
 #include "weborigin/KURL.h"
+#include "wtf/PassOwnPtr.h"
+#include "wtf/RefPtr.h"
+#include "wtf/text/WTFString.h"
+
+#include <algorithm>
 
 namespace WebCore {
-    
+
 const float kDragLabelBorderX = 4;
 // Keep border_y in synch with DragController::LinkDragBorderInset.
 const float kDragLabelBorderY = 2;
 const float kDragLabelRadius = 5;
 const float kLabelBorderYOffset = 2;
 
 const float kMinDragLabelWidthBeforeClip = 120;
 const float kMaxDragLabelWidth = 300;
 const float kMaxDragLabelStringWidth = (kMaxDragLabelWidth - 2 * kDragLabelBorderX);
 
 const float kDragLinkLabelFontSize = 11;
 const float kDragLinkUrlFontSize = 10;
 
+PassOwnPtr<DragImage> DragImage::create(Image* image, RespectImageOrientationEnum shouldRespectImageOrientation)
+{
+    if (!image)
+        return PassOwnPtr<DragImage>();

[jamesr, 2013/06/17 17:51:00]

nullptr

[jbroman, 2013/06/17 18:52:10]

Done.

+
+    RefPtr<NativeImageSkia> bitmap = image->nativeImageForCurrentFrame();
+    if (!bitmap)
+        return PassOwnPtr<DragImage>();
+
+    if (image->isBitmapImage()) {
+        ImageOrientation orientation = DefaultImageOrientation;
+        BitmapImage* bitmapImage = static_cast<BitmapImage*>(image);
+        IntSize sizeRespectingOrientation = bitmapImage->sizeRespectingOrientation();
+
+        if (shouldRespectImageOrientation == RespectImageOrientation)
+            orientation = bitmapImage->currentFrameOrientation();
+
+        if (orientation != DefaultImageOrientation) {
+            FloatRect destRect(FloatPoint(), sizeRespectingOrientation);
+            if (orientation.usesWidthAsHeight())
+                destRect = destRect.transposedRect();
+
+            SkBitmap skBitmap;
+            skBitmap.setConfig(
+                SkBitmap::kARGB_8888_Config, sizeRespectingOrientation.width(), sizeRespectingOrientation.height());
+            if (!skBitmap.allocPixels())
+                return PassOwnPtr<DragImage>();
+
+            SkCanvas canvas(skBitmap);
+            canvas.concat(orientation.transformFromDefault(sizeRespectingOrientation));
+            canvas.drawBitmapRect(bitmap->bitmap(), 0, destRect);
+
+            return adoptPtr(new DragImage(skBitmap, bitmap->resolutionScale()));
+        }
+    }
+
+    SkBitmap skBitmap;
+    if (!bitmap->bitmap().copyTo(&skBitmap, SkBitmap::kARGB_8888_Config))
+        return PassOwnPtr<DragImage>();
+    return adoptPtr(new DragImage(skBitmap, bitmap->resolutionScale()));
+}
+
 static Font dragLabelFont(int size, FontWeight fontWeight, FontRenderingMode renderingMode)
 {
     FontDescription description;
     description.setWeight(fontWeight);
-
     description.setSpecifiedSize(size);
     description.setComputedSize(size);
     description.setRenderingMode(renderingMode);
     Font result(description, 0, 0);
     result.update(0);
     return result;
 }
 
-DragImageRef fitDragImageToMaxSize(DragImageRef image, const IntSize& srcSize, const IntSize& size)
-{
-    float heightResizeRatio = 0.0f;
-    float widthResizeRatio = 0.0f;
-    float resizeRatio = -1.0f;
-    IntSize originalSize = dragImageSize(image);
-    
-    if (srcSize.width() > size.width()) {
-        widthResizeRatio = size.width() / (float)srcSize.width();
-        resizeRatio = widthResizeRatio;
-    }
-    
-    if (srcSize.height() > size.height()) {
-        heightResizeRatio = size.height() / (float)srcSize.height();
-        if ((resizeRatio < 0.0f) || (resizeRatio > heightResizeRatio))
-            resizeRatio = heightResizeRatio;
-    }
-    
-    if (srcSize == originalSize)
-        return resizeRatio > 0.0f ? scaleDragImage(image, FloatSize(resizeRatio, resizeRatio)) : image;
-    
-    // The image was scaled in the webpage so at minimum we must account for that scaling
-    float scalex = srcSize.width() / (float)originalSize.width();
-    float scaley = srcSize.height() / (float)originalSize.height();
-    if (resizeRatio > 0.0f) {
-        scalex *= resizeRatio;
-        scaley *= resizeRatio;
-    }
-    
-    return scaleDragImage(image, FloatSize(scalex, scaley));
-}
-    
-DragImageRef createDragImageForSelection(DragImageRef image, float dragImageAlpha)
-{
-    if (image)
-        image = dissolveDragImageToFraction(image, dragImageAlpha);
-    return image;
-}
-
-DragImageRef createDragImageForLink(const KURL& url, const String& inLabel, FontRenderingMode renderingMode, float deviceScaleFactor)
+PassOwnPtr<DragImage> DragImage::create(const KURL& url, const String& inLabel, FontRenderingMode renderingMode, float deviceScaleFactor)
 {
     const Font labelFont = dragLabelFont(kDragLinkLabelFontSize, FontWeightBold, renderingMode);
     const Font urlFont = dragLabelFont(kDragLinkUrlFontSize, FontWeightNormal, renderingMode);
     FontCachePurgePreventer fontCachePurgePreventer;
 
     bool drawURLString = true;
     bool clipURLString = false;
     bool clipLabelString = false;
 
     String urlString = url.string();
@@ skipping 26 matching lines @@
         } else
             imageSize.setWidth(std::max(labelSize.width(), urlStringSize.width()) + kDragLabelBorderX * 2);
     }
 
     // We now know how big the image needs to be, so we create and
     // fill the background
     IntSize scaledImageSize = imageSize;
     scaledImageSize.scale(deviceScaleFactor);
     OwnPtr<ImageBuffer> buffer(ImageBuffer::create(scaledImageSize, deviceScaleFactor));
     if (!buffer)
-        return 0;
+        return PassOwnPtr<DragImage>();
 
     const float DragLabelRadius = 5;
     const IntSize radii(DragLabelRadius, DragLabelRadius);
     IntRect rect(IntPoint(), imageSize);
     const Color backgroundColor(140, 140, 140);
     buffer->context()->fillRoundedRect(rect, radii, radii, radii, radii, backgroundColor);
 
     // Draw the text
     if (drawURLString) {
         if (clipURLString)
             urlString = StringTruncator::centerTruncate(urlString, imageSize.width() - (kDragLabelBorderX * 2.0f), urlFont, StringTruncator::EnableRoundingHacks);
         IntPoint textPos(kDragLabelBorderX, imageSize.height() - (kLabelBorderYOffset + urlFont.fontMetrics().descent()));
         TextRun textRun(urlString);
         buffer->context()->drawText(urlFont, TextRunPaintInfo(textRun), textPos);
     }
 
     if (clipLabelString)
         label = StringTruncator::rightTruncate(label, imageSize.width() - (kDragLabelBorderX * 2.0f), labelFont, StringTruncator::EnableRoundingHacks);
 
     IntPoint textPos(kDragLabelBorderX, kDragLabelBorderY + labelFont.pixelSize());
     TextRun textRun(label);
     buffer->context()->drawText(urlFont, TextRunPaintInfo(textRun), textPos);
 
     RefPtr<Image> image = buffer->copyImage();
-    return createDragImageFromImage(image.get());
+    return DragImage::create(image.get());
+}
+
+DragImage::DragImage(const SkBitmap& bitmap, float resolutionScale)
+    : m_bitmap(bitmap)
+    , m_resolutionScale(resolutionScale)
+{
+}
+
+DragImage::~DragImage()
+{
+}
+
+void DragImage::fitToMaxSize(const IntSize& srcSize, const IntSize& maxSize)
+{
+    float heightResizeRatio = 0.0f;
+    float widthResizeRatio = 0.0f;
+    float resizeRatio = -1.0f;
+    IntSize originalSize = size();
+
+    if (srcSize.width() > maxSize.width()) {
+        widthResizeRatio = maxSize.width() / (float)srcSize.width();

[jamesr, 2013/06/17 17:51:00]

we pretty much never use c-style cases in Chromium or Blink.  make this a
static_cast<float>() or rejigger the types to avoid it. you might be able to use
some of the (Int|Float)Size helpers to cut down on this per-component math a bit

[jbroman, 2013/06/17 18:52:10]

Agreed. This code is only this way because I modified the code of
fitDragImageToMaxSize as little as possible. But if you want the C-style casts
gone in this CL, then gone they shall be.

I don't see a trivial way to use the {Float,Int}Size methods to clean this up,
though.

+        resizeRatio = widthResizeRatio;
+    }
+
+    if (srcSize.height() > maxSize.height()) {
+        heightResizeRatio = maxSize.height() / (float)srcSize.height();
+        if ((resizeRatio < 0.0f) || (resizeRatio > heightResizeRatio))
+            resizeRatio = heightResizeRatio;
+    }
+
+    if (srcSize == originalSize) {
+        if (resizeRatio > 0.0f)
+            scale(resizeRatio, resizeRatio);
+        return;
+    }
+
+    // The image was scaled in the webpage so at minimum we must account for that scaling
+    float scaleX = srcSize.width() / (float)originalSize.width();
+    float scaleY = srcSize.height() / (float)originalSize.height();
+    if (resizeRatio > 0.0f) {
+        scaleX *= resizeRatio;
+        scaleY *= resizeRatio;
+    }
+
+    scale(scaleX, scaleY);
+}
+
+void DragImage::scale(float scaleX, float scaleY)
+{
+    int imageWidth = scaleX * m_bitmap.width();
+    int imageHeight = scaleY * m_bitmap.height();
+    m_bitmap = skia::ImageOperations::Resize(
+        m_bitmap, skia::ImageOperations::RESIZE_LANCZOS3, imageWidth, imageHeight);
+}
+
+void DragImage::dissolveToFraction(float fraction)
+{
+    m_bitmap.setIsOpaque(false);
+    SkAutoLockPixels lock(m_bitmap);
+
+    for (int row = 0; row < m_bitmap.height(); ++row) {
+        for (int column = 0; column < m_bitmap.width(); ++column) {
+            uint32_t* pixel = m_bitmap.getAddr32(column, row);
+            *pixel = SkPreMultiplyARGB(
+                SkColorGetA(*pixel) * fraction,
+                SkColorGetR(*pixel),
+                SkColorGetG(*pixel),
+                SkColorGetB(*pixel));
+        }
+    }
 }
 
 } // namespace WebCore
-