Source/WebKit/DEPS - Issue 16715002: Refactor WebCore::DragImage.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/WebKit/DEPS

Issue 16715002: Refactor WebCore::DragImage. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+..",	2 "+..",

3 "+bindings",	3 "+bindings",

4 "+core",	4 "+core",

5 "+modules",	5 "+modules",

6 "+painting",	6 "+painting",

7 "+public",	7 "+public",

8 "+public/platform",	8 "+public/platform",

9 "+skia",	9 "+skia",

	10 "+third_party/skia",
	jamesr 2013/06/17 17:51:00 we've been including skia headers with just #inclu we've been including skia headers with just #include "SkFooBar.h", since depending on the skia target pulls third_party/skia//include/ onto the include path. I'd rather keep it that way to keep things consistent jbroman* 2013/06/17 18:52:10 It's not consistent nowadays (if you do a Code Sea Show quoted text On 2013/06/17 17:51:00, jamesr wrote: > we've been including skia headers with just #include "SkFooBar.h", since > depending on the skia target pulls third_party/skia//include/ onto the include > path. I'd rather keep it that way to keep things consistent It's not consistent nowadays (if you do a Code Search, it shows we use relative paths about 2/3 of the time and absolute paths about 1/3 of the time when we refer to Skia headers, both inside and outside Blink). My understanding was that we preferred absolute paths and were moving in that direction as we went along. http://crrev.com/14450004 is one example of a CL (that predates me) that removed relative paths to Skia headers in one place and introduced absolute paths instead. If that's not preferred, we should probably figure out what the rules are*, so that it doesn't end up varying simply by reviewer. Thoughts?
10 "+weborigin",	11 "+weborigin",

11 ]	12 ]

OLD	NEW

« no previous file with comments | « no previous file | Source/WebKit/chromium/src/DragClientImpl.h » ('j') | Source/core/page/Frame.cpp » ('J')