Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1671473002: Remove CFX_PtrArray from fx_xml.h (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Remove CFX_PtrArray from fx_xml.h Removes another case of a void* array where the even elements mean one thing and the odd elements mean another. And even the odd elements aren't consistently typed -- leave for later. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/cdac3446f26751ff5db4123d87710f8b4e15d11c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -80 lines) Patch
M core/include/fxcrt/fx_xml.h View 7 chunks +16 lines, -24 lines 0 comments Download
M core/src/fxcrt/fx_xml_parser.cpp View 5 chunks +39 lines, -56 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, pls review.
4 years, 10 months ago (2016-02-04 18:41:19 UTC) #1
Lei Zhang
lgtm
4 years, 10 months ago (2016-02-04 19:55:31 UTC) #2
Tom Sepez
4 years, 10 months ago (2016-02-04 21:02:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cdac3446f26751ff5db4123d87710f8b4e15d11c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698