Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1671433002: Fix 'Calculating hash...' message (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, Sébastien Marchand
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix 'Calculating hash...' message Right now I get Calculating hash of toolchain in vs2013_files. Please wait... Calculating hash of toolchain in vs2013_files. Please wait... Calculating hash of toolchain in vs2013_files. Please wait... Calculating hash of toolchain in vs2013_files. Please wait... Calculating hash of toolchain in vs2013_files. Please wait... Calculating hash of toolchain in vs2013_files. Please wait... which isn't very informative (or at least a bit confusing as to why it's doing the same thing 6 times). R=brucedawson@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M win_toolchain/get_toolchain_if_necessary.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
scottmg
4 years, 10 months ago (2016-02-04 17:43:00 UTC) #1
brucedawson
Thank you for this fix. lgtm.
4 years, 10 months ago (2016-02-04 18:22:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671433002/1
4 years, 10 months ago (2016-02-04 18:27:36 UTC) #4
Sébastien Marchand
Thanks for fixing my mistakes :), lgtm
4 years, 10 months ago (2016-02-04 18:28:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298593
4 years, 10 months ago (2016-02-04 18:30:02 UTC) #8
scottmg
Ah, and that illuminates what it was actually doing, which isn't so great. ________ running ...
4 years, 10 months ago (2016-02-04 19:43:49 UTC) #9
Sébastien Marchand
They should be cleaned on the first run, as we don't have a timestamp file ...
4 years, 10 months ago (2016-02-04 19:44:51 UTC) #10
Sébastien Marchand
e.g. : from the log on the first build including this change on 'Win builder' ...
4 years, 10 months ago (2016-02-04 19:47:36 UTC) #11
scottmg
4 years, 10 months ago (2016-02-04 19:56:17 UTC) #12
Message was sent while issue was closed. 
On 2016/02/04 19:47:36, Sébastien Marchand wrote:
> e.g. : from the log on the first build including this change on 'Win builder'
>
(https://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/19500...)
> :
> 
> Calculating hash of toolchain in vs2013_files. Please wait...
> Calculating hash of toolchain in vs2013_files. Please wait...
> Calculating hash of toolchain in vs2013_files. Please wait...
> Calculating hash of toolchain in vs2013_files. Please wait...
> Calculating hash of toolchain in vs2013_files. Please wait...
> Calculating hash of toolchain in vs2013_files. Please wait...
> Removing vs2013_files\DIA SDK as it doesn't correspond to any known toolchain.
> Removing vs2013_files\sys32 as it doesn't correspond to any known toolchain.
> Removing vs2013_files\sys64 as it doesn't correspond to any known toolchain.
> Removing vs2013_files\VC as it doesn't correspond to any known toolchain.
> Removing vs2013_files\win_sdk as it doesn't correspond to any known toolchain.
> Hook ''C:\b\depot_tools\python276_bin\python.exe' src/build/vs_toolchain.py
> update' took 147.90 secs

Oh right, it did locally too. Thanks.

Powered by Google App Engine
This is Rietveld 408576698