Disable broken page in key_silk_cases.

Disable broken page in key_silk_cases.

The following page always errors out inside rasterize_and_record.key_silk_cases
on some windows platforms:
  http://plus.google.com/app/basic/stream

This change disables this page so that the perf bots can pass this test for the
other pages.

BUG=338838
R=dominikg@chromium.org, tonyg@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251358

[tonyg, 2014-02-14 16:57:17]

lgtm

[Dominik Grewe, 2014-02-14 16:57:22]

I can't see your patch. Did something go wrong at upload?

[teravest, 2014-02-14 16:58:53]

Not sure what's wrong with the side-by-side diff, but the unified diff is pretty
easy to read.

[Dominik Grewe, 2014-02-14 17:05:51]

On 2014/02/14 16:58:53, teravest wrote:
> Not sure what's wrong with the side-by-side diff, but the unified diff is
pretty
> easy to read.

Ah okay, sorry. I couldn't open the unified diff because the "Rietveld Usability
Toolkit" extension always opens side-by-side by default...

Could you just disable the page and reference the bug? This way we won't lose
track of it. Simply add something like "disabled": "Times out on Windows;
crbug.com/338838" (see other disabled pages in the set).

[tonyg, 2014-02-14 17:06:42]

On Fri, Feb 14, 2014 at 8:58 AM,  <teravest@chromium.org> wrote:
> Not sure what's wrong with the side-by-side diff, but the unified diff is
> pretty
> easy to read.

This problem is extremely common with rietveld. The workaround is to
run git cl upload again. I believe Robbie has some plans to make this
better.

>
> https://codereview.chromium.org/167143002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[teravest, 2014-02-14 17:09:52]

On 2014/02/14 17:05:51, Dominik Grewe wrote:
> On 2014/02/14 16:58:53, teravest wrote:
> > Not sure what's wrong with the side-by-side diff, but the unified diff is
> pretty
> > easy to read.
> 
> Ah okay, sorry. I couldn't open the unified diff because the "Rietveld
Usability
> Toolkit" extension always opens side-by-side by default...
> 
> Could you just disable the page and reference the bug? This way we won't lose
> track of it. Simply add something like "disabled": "Times out on Windows;
> crbug.com/338838" (see other disabled pages in the set).

Done.

[Dominik Grewe, 2014-02-14 17:10:36]

On 2014/02/14 17:09:52, teravest wrote:
> On 2014/02/14 17:05:51, Dominik Grewe wrote:
> > On 2014/02/14 16:58:53, teravest wrote:
> > > Not sure what's wrong with the side-by-side diff, but the unified diff is
> > pretty
> > > easy to read.
> > 
> > Ah okay, sorry. I couldn't open the unified diff because the "Rietveld
> Usability
> > Toolkit" extension always opens side-by-side by default...
> > 
> > Could you just disable the page and reference the bug? This way we won't
lose
> > track of it. Simply add something like "disabled": "Times out on Windows;
> > crbug.com/338838" (see other disabled pages in the set).
> 
> Done.

Thanks! LGTM.

[teravest, 2014-02-14 17:15:35]

Committed patchset #2 manually as r251358 (presubmit successful).

[iannucci, 2014-02-19 00:47:35]

Yep, Rietveld is getting a rewrite and a lot of these stability /
inconsistency issues should go away (plus, uploads will be a lot faster).
I'm working on the chrome -> git transition at the moment, so I can't give
an ETA, but it's on our medium-range radar.


On Fri, Feb 14, 2014 at 9:05 AM, Tony Gentilcore <tonyg@chromium.org> wrote:

> On Fri, Feb 14, 2014 at 8:58 AM,  <teravest@chromium.org> wrote:
> > Not sure what's wrong with the side-by-side diff, but the unified diff is
> > pretty
> > easy to read.
>
> This problem is extremely common with rietveld. The workaround is to
> run git cl upload again. I believe Robbie has some plans to make this
> better.
>
> >
> > https://codereview.chromium.org/167143002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.