Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1671383003: [Onion Soup] Remove dead memory usage code in BlinkPlatformImpl. (Closed)

Created:
4 years, 10 months ago by esprehn
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Onion Soup] Remove dead memory usage code in BlinkPlatformImpl. Nothing calls these methods, and this complicated cache is never used. The cache also doesn't make sense since these APIs are only used on the main thread so there's no reason to have locks. BUG=561879 Committed: https://crrev.com/449127a5b216bf5b67fb0caf79c7365c9cf09419 Cr-Commit-Position: refs/heads/master@{#374083}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -89 lines) Patch
M content/child/blink_platform_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/blink_platform_impl.cc View 2 chunks +1 line, -73 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
esprehn
4 years, 10 months ago (2016-02-06 02:40:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671383003/1
4 years, 10 months ago (2016-02-06 02:41:25 UTC) #4
haraken
LGTM
4 years, 10 months ago (2016-02-06 02:46:57 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/19371)
4 years, 10 months ago (2016-02-06 03:20:58 UTC) #7
kinuko
lgtm.
4 years, 10 months ago (2016-02-08 01:58:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671383003/1
4 years, 10 months ago (2016-02-08 03:37:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 05:07:42 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 05:09:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/449127a5b216bf5b67fb0caf79c7365c9cf09419
Cr-Commit-Position: refs/heads/master@{#374083}

Powered by Google App Engine
This is Rietveld 408576698