Source/platform/graphics/ImageDecodingStore.cpp - Issue 167123002: Simpler return value from HashTable::add()/HashMap::add() and others

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/ImageDecodingStore.cpp

Issue 167123002: Simpler return value from HashTable::add()/HashMap::add() and others (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/graphics/ImageDecodingStore.cpp

diff --git a/Source/platform/graphics/ImageDecodingStore.cpp b/Source/platform/graphics/ImageDecodingStore.cpp

index 5e7bb4d43afb97fec331eafe4a7a562addf309b6..a6e1fda5ef59a2d9bb92e29da723bf655bf2fa1f 100644

--- a/Source/platform/graphics/ImageDecodingStore.cpp

+++ b/Source/platform/graphics/ImageDecodingStore.cpp

@@ -367,7 +367,7 @@ void ImageDecodingStore::insertCacheInternal(PassOwnPtr<T> cacheEntry, U* cacheM

typename U::KeyType key = cacheEntry->cacheKey();

typename V::AddResult result = identifierMap->add(cacheEntry->generator(), typename V::MappedType());

- result.iterator->value.add(key);

+ result.storedValue->value.add(key);

cacheMap->add(key, cacheEntry);

TRACE_COUNTER1("webkit", "ImageDecodingStoreDiscardableMemoryUsageBytes", m_discardableMemoryUsageInBytes);

« no previous file with comments | « Source/platform/fonts/win/UniscribeHelper.cpp ('k') | Source/platform/network/ResourceRequest.cpp » ('j') | no next file with comments »