Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Unified Diff: Source/platform/fonts/harfbuzz/HarfBuzzFace.cpp

Issue 167123002: Simpler return value from HashTable::add()/HashMap::add() and others (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/fonts/WidthCache.h ('k') | Source/platform/fonts/harfbuzz/HarfBuzzFaceSkia.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/harfbuzz/HarfBuzzFace.cpp
diff --git a/Source/platform/fonts/harfbuzz/HarfBuzzFace.cpp b/Source/platform/fonts/harfbuzz/HarfBuzzFace.cpp
index b35f636353acd212156b44cdbb2eed2823ccbb8f..9c3171b6b935bc856b0551a4446f1c291cdf3662 100644
--- a/Source/platform/fonts/harfbuzz/HarfBuzzFace.cpp
+++ b/Source/platform/fonts/harfbuzz/HarfBuzzFace.cpp
@@ -84,10 +84,10 @@ HarfBuzzFace::HarfBuzzFace(FontPlatformData* platformData, uint64_t uniqueID)
{
HarfBuzzFaceCache::AddResult result = harfBuzzFaceCache()->add(m_uniqueID, 0);
if (result.isNewEntry)
- result.iterator->value = FaceCacheEntry::create(createFace());
- result.iterator->value->ref();
- m_face = result.iterator->value->face();
- m_glyphCacheForFaceCacheEntry = result.iterator->value->glyphCache();
+ result.storedValue->value = FaceCacheEntry::create(createFace());
+ result.storedValue->value->ref();
+ m_face = result.storedValue->value->face();
+ m_glyphCacheForFaceCacheEntry = result.storedValue->value->glyphCache();
}
HarfBuzzFace::~HarfBuzzFace()
« no previous file with comments | « Source/platform/fonts/WidthCache.h ('k') | Source/platform/fonts/harfbuzz/HarfBuzzFaceSkia.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698