Source/core/dom/QualifiedName.cpp - Issue 167123002: Simpler return value from HashTable::add()/HashMap::add() and others

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/QualifiedName.cpp

Issue 167123002: Simpler return value from HashTable::add()/HashMap::add() and others (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/QualifiedName.cpp

diff --git a/Source/core/dom/QualifiedName.cpp b/Source/core/dom/QualifiedName.cpp

index de0ba4185f189b3c21df567de4830e9803c8d2f4..4400201a5628d53885e0715f4127da8e0b7977e7 100644

--- a/Source/core/dom/QualifiedName.cpp

+++ b/Source/core/dom/QualifiedName.cpp

@@ -77,7 +77,7 @@ QualifiedName::QualifiedName(const AtomicString& p, const AtomicString& l, const

{

QualifiedNameComponents components = { p.impl(), l.impl(), n.isEmpty() ? nullAtom.impl() : n.impl() };

QualifiedNameCache::AddResult addResult = qualifiedNameCache().add<QNameComponentsTranslator>(components);

- m_impl = addResult.isNewEntry ? adoptRef(*addResult.iterator) : *addResult.iterator;

+ m_impl = addResult.isNewEntry ? adoptRef(*addResult.storedValue) : *addResult.storedValue;

}

QualifiedName::~QualifiedName()

« no previous file with comments | « Source/core/dom/PresentationAttributeStyle.cpp ('k') | Source/core/dom/SpaceSplitString.cpp » ('j') | no next file with comments »