Source/core/dom/ElementDataCache.cpp - Issue 167123002: Simpler return value from HashTable::add()/HashMap::add() and others

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ElementDataCache.cpp

Issue 167123002: Simpler return value from HashTable::add()/HashMap::add() and others (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/ElementDataCache.cpp

diff --git a/Source/core/dom/ElementDataCache.cpp b/Source/core/dom/ElementDataCache.cpp

index f5dc770d275e4850bc3fdd8e361383162782b2e3..1b3cf32b4e1a8b8340a330b75b14418588ed0f78 100644

--- a/Source/core/dom/ElementDataCache.cpp

+++ b/Source/core/dom/ElementDataCache.cpp

@@ -47,7 +47,7 @@ PassRefPtr<ShareableElementData> ElementDataCache::cachedShareableElementDataWit

{

ASSERT(!attributes.isEmpty());

- ShareableElementDataCache::iterator it = m_shareableElementDataCache.add(attributeHash(attributes), 0).iterator;

+ ShareableElementDataCache::ValueType* it = m_shareableElementDataCache.add(attributeHash(attributes), 0).storedValue;

// FIXME: This prevents sharing when there's a hash collision.

if (it->value && !hasSameAttributes(attributes, *it->value))

« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/dom/ExecutionContext.cpp » ('j') | no next file with comments »