Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: ash/display/display_error_observer_chromeos.cc

Issue 1671223002: Revert of Give user ability to file a feedback report from the display error notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/ash_chromeos_strings.grdp ('k') | ui/display/chromeos/display_snapshot_virtual.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/display/display_error_observer_chromeos.cc
diff --git a/ash/display/display_error_observer_chromeos.cc b/ash/display/display_error_observer_chromeos.cc
index 7a11b6dcae031f11c8aa29bbda8b4adb25b1fa50..c08e6402da45394b01d650ecc0de98a094d06851 100644
--- a/ash/display/display_error_observer_chromeos.cc
+++ b/ash/display/display_error_observer_chromeos.cc
@@ -4,13 +4,9 @@
#include "ash/display/display_error_observer_chromeos.h"
-#include <cinttypes>
#include <utility>
-#include "ash/new_window_delegate.h"
-#include "ash/shell.h"
#include "ash/system/system_notifier.h"
-#include "base/strings/string_number_conversions.h"
#include "grit/ash_resources.h"
#include "grit/ash_strings.h"
#include "ui/base/l10n/l10n_util.h"
@@ -27,27 +23,6 @@
const char kDisplayErrorNotificationId[] = "chrome://settings/display/error";
-// A notification delegate that will start the feedback app when the notication
-// is clicked.
-class DisplayErrorNotificationDelegate
- : public message_center::NotificationDelegate {
- public:
- DisplayErrorNotificationDelegate() = default;
-
- // message_center::NotificationDelegate:
- bool HasClickedListener() override { return true; }
-
- void Click() override {
- ash::Shell::GetInstance()->new_window_delegate()->OpenFeedbackPage();
- }
-
- private:
- // Private destructor since NotificationDelegate is ref-counted.
- ~DisplayErrorNotificationDelegate() override = default;
-
- DISALLOW_COPY_AND_ASSIGN(DisplayErrorNotificationDelegate);
-};
-
} // namespace
DisplayErrorObserver::DisplayErrorObserver() {
@@ -59,14 +34,6 @@
void DisplayErrorObserver::OnDisplayModeChangeFailed(
const ui::DisplayConfigurator::DisplayStateList& displays,
ui::MultipleDisplayState new_state) {
- LOG(ERROR) << "Failed to configure the following display(s):";
- for (const auto& display : displays) {
- LOG(ERROR) << "- Display with ID = " << display->display_id()
- << ", and EDID = " << base::HexEncode(display->edid().data(),
- display->edid().size())
- << ".";
- }
-
// Always remove the notification to make sure the notification appears
// as a popup in any situation.
message_center::MessageCenter::Get()->RemoveNotification(
@@ -86,8 +53,7 @@
GURL(),
message_center::NotifierId(message_center::NotifierId::SYSTEM_COMPONENT,
system_notifier::kNotifierDisplayError),
- message_center::RichNotificationData(),
- new DisplayErrorNotificationDelegate));
+ message_center::RichNotificationData(), NULL));
message_center::MessageCenter::Get()->AddNotification(
std::move(notification));
}
« no previous file with comments | « ash/ash_chromeos_strings.grdp ('k') | ui/display/chromeos/display_snapshot_virtual.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698