Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: ui/display/util/x11/edid_parser_x11.h

Issue 1671223002: Revert of Give user ability to file a feedback report from the display error notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/display/types/display_snapshot.cc ('k') | ui/display/util/x11/edid_parser_x11.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/display/util/x11/edid_parser_x11.h
diff --git a/ui/display/util/x11/edid_parser_x11.h b/ui/display/util/x11/edid_parser_x11.h
index 43f8cd1a48fe8c0564b6259495b289f789959466..55048e699e4a26c1cdbe3b57082c18f606e0fac8 100644
--- a/ui/display/util/x11/edid_parser_x11.h
+++ b/ui/display/util/x11/edid_parser_x11.h
@@ -8,9 +8,7 @@
#include <stdint.h>
#include <string>
-#include <vector>
-#include "base/macros.h"
#include "ui/display/types/display_constants.h"
#include "ui/display/util/display_util_export.h"
@@ -21,39 +19,21 @@
namespace ui {
-// Xrandr utility class to help get EDID information.
-class DISPLAY_UTIL_EXPORT EDIDParserX11 {
- public:
- EDIDParserX11(XID output_id);
- ~EDIDParserX11();
+// Gets the EDID data from |output| and generates the display id through
+// |GetDisplayIdFromEDID|.
+DISPLAY_UTIL_EXPORT bool GetDisplayId(XID output,
+ uint8_t index,
+ int64_t* display_id_out);
- // Sets |out_display_id| to the display ID from the EDID of this output.
- // Returns true if successful, false otherwise.
- bool GetDisplayId(uint8_t index, int64_t* out_display_id) const;
+// Generate the human readable string from EDID obtained from |output|.
+DISPLAY_UTIL_EXPORT std::string GetDisplayName(RROutput output);
- // Generate the human readable string from EDID obtained from |output|.
- // Returns an empty string upon error.
- std::string GetDisplayName() const;
-
- // Gets the overscan flag and stores to |out_flag|. Returns true if the flag
- // is found. Otherwise returns false and doesn't touch |out_flag|. The output
- // will produce overscan if |out_flag| is set to true, but the output may
- // still produce overscan even though it returns true and |out_flag| is set to
- // false.
- bool GetOutputOverscanFlag(bool* out_flag) const;
-
- XID output_id() const { return output_id_; }
- const std::vector<uint8_t>& edid() const { return edid_; }
-
- private:
- XID output_id_;
-
- // This will be an empty vector upon failure to get the EDID from the
- // |output_id_|.
- std::vector<uint8_t> edid_;
-
- DISALLOW_COPY_AND_ASSIGN(EDIDParserX11);
-};
+// Gets the overscan flag from |output| and stores to |flag|. Returns true if
+// the flag is found. Otherwise returns false and doesn't touch |flag|. The
+// output will produce overscan if |flag| is set to true, but the output may
+// still produce overscan even though it returns true and |flag| is set to
+// false.
+DISPLAY_UTIL_EXPORT bool GetOutputOverscanFlag(RROutput output, bool* flag);
} // namespace ui
« no previous file with comments | « ui/display/types/display_snapshot.cc ('k') | ui/display/util/x11/edid_parser_x11.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698