Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1671223002: Revert of Give user ability to file a feedback report from the display error notification. (Closed)

Created:
4 years, 10 months ago by please use gerrit instead
Modified:
4 years, 10 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, tdanderson+views_chromium.org, sadrul, tfarina, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Give user ability to file a feedback report from the display error notification. (patchset #5 id:80001 of https://codereview.chromium.org/1636153002/ ) Reason for revert: Missing include causing compile failure in win64: FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\4087e065abebdca6dbd0caca2910c6718d2ec67f\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/ui/display/types/types/display_snapshot.obj.rsp /c ../../ui/display/types/display_snapshot.cc /Foobj/ui/display/types/types/display_snapshot.obj /Fdobj/ui/display/types/types_cc.pdb e:\b\build\slave\win_x64_gn\build\src\ui\display\types\display_snapshot.cc(46) : error C2039: 'min' : is not a member of 'std' e:\b\build\slave\win_x64_gn\build\src\ui\display\types\display_snapshot.cc(46) : error C3861: 'min': identifier not found ninja: build stopped: subcommand failed. Original issue's description: > Give user ability to file a feedback report from the display error notification. > > Make the display error notification clickable and starts the feedback app on click. > We log the available displays IDs and EDIDs. > > BUG=570380 > TEST=manually > > Committed: https://crrev.com/965f9b3c3a245b52b8720cecbd598576853ba719 > Cr-Commit-Position: refs/heads/master@{#373895} TBR=spang@chromium.org,erg@chromium.org,kenrb@chromium.org,oshima@chromium.org,afakhry@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570380 Committed: https://crrev.com/ed0a3fbd38fdcc85b6d935331f05b88b5e81be83 Cr-Commit-Position: refs/heads/master@{#373910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -139 lines) Patch
M ash/ash_chromeos_strings.grdp View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/display_error_observer_chromeos.cc View 4 chunks +1 line, -35 lines 0 comments Download
M ui/display/chromeos/display_snapshot_virtual.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/display/chromeos/test/test_display_snapshot.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/display/chromeos/x11/display_snapshot_x11.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/display/chromeos/x11/display_snapshot_x11.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ui/display/chromeos/x11/native_display_event_dispatcher_x11_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/display/types/display_snapshot.h View 3 chunks +0 lines, -6 lines 0 comments Download
M ui/display/types/display_snapshot.cc View 3 chunks +1 line, -20 lines 0 comments Download
M ui/display/util/x11/edid_parser_x11.h View 2 chunks +13 lines, -33 lines 0 comments Download
M ui/display/util/x11/edid_parser_x11.cc View 1 chunk +32 lines, -19 lines 0 comments Download
M ui/ozone/common/display_snapshot_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/common/display_util.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ozone/common/gpu/ozone_gpu_message_params.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/common/gpu/ozone_gpu_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/common/drm_util.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
please use gerrit instead
Created Revert of Give user ability to file a feedback report from the display error ...
4 years, 10 months ago (2016-02-05 20:58:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671223002/1
4 years, 10 months ago (2016-02-05 21:00:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671223002/1
4 years, 10 months ago (2016-02-05 21:04:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 21:10:28 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 22:03:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed0a3fbd38fdcc85b6d935331f05b88b5e81be83
Cr-Commit-Position: refs/heads/master@{#373910}

Powered by Google App Engine
This is Rietveld 408576698