Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1671213002: Fix build broken at e059b5ba1260 (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M xfa/src/fwl/src/lightwidget/combobox.cpp View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR, fix build. I tried changing these all to size_t, but it went too deep ...
4 years, 10 months ago (2016-02-05 20:45:42 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 9c98adb0404c4b161ceb71953772b79983afa55d (tree was closed).
4 years, 10 months ago (2016-02-05 20:46:01 UTC) #3
Lei Zhang
4 years, 10 months ago (2016-02-05 20:55:15 UTC) #4
Message was sent while issue was closed.
On 2016/02/05 20:45:42, Tom Sepez wrote:
> TBR, fix build.  I tried changing these all to size_t, but it went too deep
for
> a quick fix.

Ya, some day...

lgtm

Powered by Google App Engine
This is Rietveld 408576698