Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 1671193003: Indexed DB: Remove transaction throttle (Closed)

Created:
4 years, 10 months ago by jsbell
Modified:
4 years, 10 months ago
Reviewers:
cmumford
CC:
chromium-reviews, darin-cc_chromium.org, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Indexed DB: Remove transaction throttle A transaction throttle was introduced in https://crrev.com/1511973004 to mitigate behavior where a renderer was issuing transactions faster than they could be processed, leading to eventual OOM. Unfortunately, it looks like some apps are relying on behavior that trips this throttle, so we need to rethink it. Remove the throttle, but keep recording UMA stats. R=cmumford@chromium.org BUG=338800, 584768 Committed: https://crrev.com/8b348ae7675a7db880b2dee87a582a79377d8fa8 Cr-Commit-Position: refs/heads/master@{#374443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M content/browser/indexed_db/indexed_db_database.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jsbell
cmumford@ - please take a look (and CQ?)
4 years, 10 months ago (2016-02-06 00:49:17 UTC) #1
cmumford
lgtm
4 years, 10 months ago (2016-02-08 16:57:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671193003/1
4 years, 10 months ago (2016-02-08 16:58:02 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/19854)
4 years, 10 months ago (2016-02-08 20:12:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671193003/1
4 years, 10 months ago (2016-02-09 17:16:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 20:18:21 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 20:20:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b348ae7675a7db880b2dee87a582a79377d8fa8
Cr-Commit-Position: refs/heads/master@{#374443}

Powered by Google App Engine
This is Rietveld 408576698