Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: include/core/SkPicture.h

Issue 1671193002: Make SkPicture/SkImageGenerator default to SkCodec (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Add references to bugs Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/tools.gyp ('k') | public.bzl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkPicture.h
diff --git a/include/core/SkPicture.h b/include/core/SkPicture.h
index 720747e9a3232eeb9b07931b1ad1e939f489e511..ba9c5ff77a787c71fa420e4f956d6a2045d7a7cc 100644
--- a/include/core/SkPicture.h
+++ b/include/core/SkPicture.h
@@ -46,6 +46,11 @@ public:
*/
typedef bool (*InstallPixelRefProc)(const void* src, size_t length, SkBitmap* dst);
+ // FIXME: Replace this with an interface that creates an SkImageGenerator.
+ // skbug.com/4883
+ // skbug.com/4290
+ static bool DefaultInstall(const void*, size_t, SkBitmap*);
+
/**
* Recreate a picture that was serialized into a stream.
* @param SkStream Serialized picture data. Ownership is unchanged by this call.
@@ -54,8 +59,7 @@ public:
* @return A new SkPicture representing the serialized data, or NULL if the stream is
* invalid.
*/
- static SkPicture* CreateFromStream(SkStream*,
- InstallPixelRefProc proc = &SkImageDecoder::DecodeMemory);
+ static SkPicture* CreateFromStream(SkStream*, InstallPixelRefProc proc = &DefaultInstall);
reed1 2016/02/09 15:29:53 Do we need to expose DefaultInstall() directly? i.
scroggo 2016/02/09 16:12:17 Done.
/**
* Recreate a picture that was serialized into a buffer. If the creation requires bitmap
« no previous file with comments | « gyp/tools.gyp ('k') | public.bzl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698